Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis fix #91

Merged
merged 13 commits into from
Jun 28, 2016
Merged

Travis fix #91

merged 13 commits into from
Jun 28, 2016

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jun 28, 2016

Fixes #89

As we will might need to upgrade the omego schema sorting logic to handle new patterns (see ome/openmicroscopy#4732), restoring the validation of individual Pull Requests via Travis might become a priority.

This PR should do the following:

  • install the custom Ice 3.5 build similarly to the strategy used in openmicroscopy Travis builds
  • switch travis-build tests to consume release builds rather than depending on CI job nomenclature

@manics
Copy link
Member

manics commented Jun 28, 2016

@manics
Copy link
Member

manics commented Jun 28, 2016

Actually ignore my previous comment, you'll probably need it to get all the dependencies

@sbesson
Copy link
Member Author

sbesson commented Jun 28, 2016

@manics: can try in a separate build. Last time I checked it was still required for installing some of the dependencies of the custom Ice 3.5 build for Ubuntu 12.04.

@sbesson
Copy link
Member Author

sbesson commented Jun 28, 2016

See https://travis-ci.org/sbesson/omego/jobs/140756186, I will push an extra commit to document the dependency for the future though.

@manics
Copy link
Member

manics commented Jun 28, 2016

👍 @sbesson

@manics manics merged commit 9657fc6 into ome:master Jun 28, 2016
@sbesson sbesson deleted the travis_fix branch June 28, 2016 10:34
@sbesson sbesson added this to the 0.4.1 milestone Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants