-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dataset_ID param to export script #296
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting them in the image source dataset. Where should the dataset ID be
entered?
…On Tue, Jun 5, 2018 at 9:50 PM, Will Moore ***@***.***> wrote:
When exporting a Figure as a new Image in OMERO, this allows us to choose
a Dataset to add the new Image to (instead of using the same Dataset that
images in the figure are in).
This isn't supported in the UI yet.
To test:
- This can be tested in the Script menu...
- Open a Figure to export and File -> Export as JSON.
- Select All and Copy the JSON.
- Go to webclient, Run Script -> Figure scripts -> Figure to Pdf
- Paste the JSON in first field
- Select Export Option: "OMERO"
- Enter a Dataset ID
- Enter a URL in Webclient URI: e.g.http://localhost
- Run Script.
Figure should be exported as new Image in the Dataset specified.
cc @jstitlow <https://github.com/jstitlow>
------------------------------
You can view, comment on, or merge this pull request online at:
#296
Commit Summary
- Add Dataset_ID param to export script
File Changes
- *M* omero_figure/scripts/omero/figure_scripts/Figure_To_Pdf.py
<https://github.com/ome/omero-figure/pull/296/files#diff-0> (23)
Patch Links:
- https://github.com/ome/omero-figure/pull/296.patch
- https://github.com/ome/omero-figure/pull/296.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#296>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFjBBgyKtxwLWfIb3qPcw8kjqCkPX6sxks5t5u8fgaJpZM4UbiOQ>
.
|
Of course, it isn't added yet. Sorry.
…On Tue, Jun 5, 2018 at 9:50 PM, Will Moore ***@***.***> wrote:
When exporting a Figure as a new Image in OMERO, this allows us to choose
a Dataset to add the new Image to (instead of using the same Dataset that
images in the figure are in).
This isn't supported in the UI yet.
To test:
- This can be tested in the Script menu...
- Open a Figure to export and File -> Export as JSON.
- Select All and Copy the JSON.
- Go to webclient, Run Script -> Figure scripts -> Figure to Pdf
- Paste the JSON in first field
- Select Export Option: "OMERO"
- Enter a Dataset ID
- Enter a URL in Webclient URI: e.g.http://localhost
- Run Script.
Figure should be exported as new Image in the Dataset specified.
cc @jstitlow <https://github.com/jstitlow>
------------------------------
You can view, comment on, or merge this pull request online at:
#296
Commit Summary
- Add Dataset_ID param to export script
File Changes
- *M* omero_figure/scripts/omero/figure_scripts/Figure_To_Pdf.py
<https://github.com/ome/omero-figure/pull/296/files#diff-0> (23)
Patch Links:
- https://github.com/ome/omero-figure/pull/296.patch
- https://github.com/ome/omero-figure/pull/296.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#296>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFjBBgyKtxwLWfIb3qPcw8kjqCkPX6sxks5t5u8fgaJpZM4UbiOQ>
.
|
@jstitlow Apologies for dropping this... Is this feature still useful to you? |
Yes, but this function will mostly be used for programmatic export in our
application. Is it already possible to assign a dataset ID when exporting
figures from a Python script?
Defaulting to the dataset ID of the first image is the ideal default
behavior for Figure export.
Thanks,
j
On Sep 24, 2018 05:24, "Will Moore" <notifications@github.com> wrote:
@jstitlow <https://github.com/jstitlow> Apologies for dropping this... Is
this feature still useful to you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#296 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFjBBtNvnSPy_SpY4HiX7yf4MVkmsb5kks5ueKTXgaJpZM4UbiOQ>
.
|
@jstitlow Currently there's no support in the released script for specifying a Dataset_ID as a script parameter. The current behaviour is to use the Dataset of the first Image in the figure, and this remains the default in this PR if no Dataset_ID is specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting a Figure as a new Image in OMERO, this allows us to choose
a Dataset to add the new Image to (instead of using the same Dataset that images in the figure are in).
This isn't supported in the UI yet.
To test:
File -> Export as JSON
.http://localhost
cc @jstitlow