Share #19
Share #19
Conversation
|
Shares are completely broken now (see https://forum.image.sc/t/omero-sharing-data-with-users-you-are-not-in-a-group-with/48520) - You can't actually see any user, apart from those that can already see your data. |
But this PR is not about the fate of the feature, it just adds a pointer to warning and a suggestion of a workaround to docs. |
|
OK, let's not hold this PR up, waiting on ome/omero-web#179. But even without any change, I think the "Shares are deprecated" message is already out of date. It should be a "Known issue: Shares are broken" and will be removed soon. |
|
The message I was envisaging is saying "Do not use this. Do not lose your time. We will not fix this." You are right, it seems best not to go ahead with this PR, as the messsage now has too many unknowns and would have to be watered down, which might again lose time of the users trying to explore the feature. cc @jburel |
docs/data-management.rst
Outdated
| Shares are deprecated | ||
| ~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Duplicating and moving the data into another group as described in :ref:`Duplicate feature<Duplicatecli>` is the recommended way you can share objects in OMERO with users who are not members of the group where the data are located. Please **do not use the** ``Shares`` tab |image6| above the left-hand pane in OMERO.web to create new Shares as this feature is deprecated and not supported and tested any more. The deprecation warning will be added to OMERO.web in future. |
There was a problem hiding this comment.
"Do not use the Shares tab....to create new Shares..." Shares aren't created in this tab. They are created with the "World" button in the Tree toolbar.
|
I think I reformulated the text here to adjust for new realities. I guess we wait with merging here until we have ome/omero-web#179 sorted. Then, we could release in sync ? |
|
@will-moore I can see that in ome/omero-web#265 you are going for wording "Not supported" where I use here "discontinued". Do you want to suggest reformulations here accordingly ? |
|
I don't think we need to worry about "Not supported" vv "discontinued". Both are fine and interchangeable |
|
thanks @will-moore , the #19 (comment) is fixed in 2b11212 |
|
👍 |
|
The commit c6be04a fixes the comment of @will-moore on ome/www.openmicroscopy.org#447 (comment) |
Co-authored-by: Josh Moore <j.a.moore@dundee.ac.uk>
docs/data-management.rst
Outdated
| Shares (discontinued feature) | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Previously created Shares can still be viewed in the ``Shares`` tab |image6| above the left-hand side pane of OMERO.web. Nevertheless, the Shares feature is discontinued. **It is not posssible to use the** ``World`` icon |image7| above the left-hand pane in OMERO.web to create new Shares anymore. Shares have been deprecated in OMERO 5.3.0 and are discontinued in OMERO.web xxx and later. You need to use the OMERO standard permissions to share Images, by :ref:`moving the data<Movedowners>` into the appropriate group. If you also want to retain the Images in their current group, you can first duplicate them as described in :ref:`Duplicate feature<Duplicatecli>`. Nevertheless, this :ref:`Duplicate<Duplicatecli>` and :ref:`Move<Movedowners>` workflow has following limitations: |
There was a problem hiding this comment.
It was actually OMERO.server 5.6.1 that 'broke' shares (meant you couldn't see users who weren't in your own groups). But probably don't need that detail here.
|
|
||
| - :ref:`Duplicate<Duplicatecli>` is only available on the Command Line Interface (CLI) | ||
| - You need to already be in a non-private group with the user you wish to share with | ||
| - You will also be sharing the data with all the other members of that group |
There was a problem hiding this comment.
At least on https://github.com/pwalczysko/omero-guide-introduction/blob/share/docs/data-management.rst page, these haven't formatted correctly. They have an extra space before -
There was a problem hiding this comment.
the rendering on https://github.com/pwalczysko/omero-guide-introduction/blob/share/docs/data-management.rst is not relevant. Try to complare the rendering of an existing link (not changed in this PR) on github with the correct rendering on the released guide in
The rendering of an existing link (not changed in this PR) on github
This renders correctly in https://omero-guides.readthedocs.io/projects/introduction/en/latest/data-management.html?highlight=%22Duplicate%20feature%22#manage-images-in-datasets-projects
The markdown on the line matches to what was there before in places such as screenshotted above. It also renders correctly if you do make clean html with local sphinx.
|
Looks good. To be merged when 5.9.0 is out |
|
Maybe we should merge and release, as all the other pieces are in place and deployed now ? |
A suggestion which tries to solve ome/omero-guides#80
Happy to move this to a better place if this is what we want. As it is laid out now, we can link to the particular Share paragraph specifically
cc @jburel @joshmoore