Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons: use percentage #7

Merged
merged 5 commits into from
May 20, 2020
Merged

icons: use percentage #7

merged 5 commits into from
May 20, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented May 12, 2020

The logos appear smaller but they are not squashed
Screenshot 2020-05-12 at 11 55 08

@mtbc
Copy link
Member

mtbc commented May 13, 2020

Given the high-DPI displays becoming commonplace could em be a better choice of unit than px?

@joshmoore
Copy link
Member

Hmmm.... building locally in a narrow window I see them squashed down rather than wide as in #6:

Screen Shot 2020-05-17 at 18 27 46

@jburel
Copy link
Member Author

jburel commented May 18, 2020

I am not sure we will have a magic solution. Maybe we need to rethink the layout

@manics
Copy link
Member

manics commented May 18, 2020

@will-moore might know? Presumably this sort of thing is standard for a responsive layout?

@will-moore
Copy link
Member

If you override the max-width:100% on img (theme.css line 3) and .rst-content img (theme.css line 6) then you get larger images:

Screenshot 2020-05-18 at 14 05 16

Needs some custom css e.g. https://docs.readthedocs.io/en/stable/guides/adding-custom-css.html

@jburel
Copy link
Member Author

jburel commented May 18, 2020

@will-moore do you want to push a commit to my branch or open a PR against it?

@jburel
Copy link
Member Author

jburel commented May 19, 2020

thanks @will-moore This is better

@jburel
Copy link
Member Author

jburel commented May 20, 2020

Screenshot 2020-05-20 at 13 36 17

Screenshot 2020-05-20 at 13 36 33

Screenshot 2020-05-20 at 13 36 54

Screenshot 2020-05-20 at 13 45 35

Tested in Tor, Safari, Chrome and Safari

It looks better

@jburel jburel merged commit 3a2d520 into ome:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants