-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fiji: Crop option #114
Fiji: Crop option #114
Conversation
src/main/java/org/openmicroscopy/shoola/env/ui/TaskBarManager.java
Outdated
Show resolved
Hide resolved
Looks good. Just wondering about the modified import statements. Possible improvements: The default crop region is the whole image, in which case you'll get the error again (don't know from the top of my head if that could be somehow smartly adjusted too). Once the crop option is ticked because a large image was opened, then this becomes the default. Wonder if it should be unticked again automatically when a non-large image is attempted to be opened. |
I will look into setting the crop dimensions |
Looks good 👍 Tested with a local build again, works as expected. Automatically setting a reasonable crop region can be done in follow-up PR, if possible at all. |
Still looks good 👍 |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/ice-unknownlocalexception-null/53973/9 |
select the crop option if large image
to test:
cc @dominikl