Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiji: Crop option #114

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Fiji: Crop option #114

merged 4 commits into from
Mar 17, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented Mar 12, 2020

select the crop option if large image
to test:

  • Open a small image in Fiji, the crop option should not be selected
  • Open a large image (image requiring pyramid), the crop option should be selected

cc @dominikl

@jburel jburel mentioned this pull request Mar 12, 2020
@dominikl
Copy link
Member

Looks good. Just wondering about the modified import statements. Possible improvements: The default crop region is the whole image, in which case you'll get the error again (don't know from the top of my head if that could be somehow smartly adjusted too). Once the crop option is ticked because a large image was opened, then this becomes the default. Wonder if it should be unticked again automatically when a non-large image is attempted to be opened.

@jburel
Copy link
Member Author

jburel commented Mar 13, 2020

I will look into setting the crop dimensions

@jburel
Copy link
Member Author

jburel commented Mar 13, 2020

@dominikl crop options will be reset.
I have not found a way to specify the region in the string
I tried X_Coordinate_1 (and lower case) etc. but it is not picked
cc @dgault

@dominikl
Copy link
Member

Looks good 👍 Tested with a local build again, works as expected. Automatically setting a reasonable crop region can be done in follow-up PR, if possible at all.

@dominikl
Copy link
Member

Still looks good 👍

@jburel jburel merged commit c796438 into ome:master Mar 17, 2020
@jburel jburel deleted the fiji_open_image branch July 1, 2020 12:45
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/ice-unknownlocalexception-null/53973/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants