Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove canLink method #133

Merged
merged 1 commit into from
May 7, 2020
Merged

Remove canLink method #133

merged 1 commit into from
May 7, 2020

Conversation

dominikl
Copy link
Member

@dominikl dominikl commented May 6, 2020

Removes the canLink method, which only checks if the dragged object belongs to the logged in user, and if it doesn't prevents the DnD action. I wonder why this method was there, because one doesn't necessarily have to be the owner of the object in order to be allowed to move it (see #131 ).

Test: Check the scenario mentioned in the above issue now works.

@jburel
Copy link
Member

jburel commented May 7, 2020

  • User can move his/her own data. The checks are correct
  • User with suitable permissions can move other users' data.
  • User without enough permissions cannot move other user's data

@jburel
Copy link
Member

jburel commented May 7, 2020

One RFE. The message could be improved to "you do not have the correct permissions" in
This should be done in a follow-up PR.

@jburel jburel merged commit f20de87 into ome:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants