Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importdialog closeable #195

Merged
merged 5 commits into from
Feb 16, 2021
Merged

Importdialog closeable #195

merged 5 commits into from
Feb 16, 2021

Conversation

dominikl
Copy link
Member

Prevent to close the ImportDialog tab. Fixes #181 .

Test:
Right click on the "Select data to import" tab. Without the fix the "Close, Close All, etc." dialog will show up. If you close the tab via this dialog, close the importer dialog and open it again, it'll crash with the IllegalComponentStateException. With the fix you shouldn't have the possibility to close this tab.
Screen Shot 2021-01-26 at 15 28 02

@dominikl dominikl mentioned this pull request Jan 26, 2021
@jburel
Copy link
Member

jburel commented Feb 5, 2021

  • The right-click menu is no longer available for the Select data to import tab
  • If I import an image, a new tab is added: The menu is then available as expected.
  • If you select Close Others, the Select data to import tab is removed and cannot be brought back
  • If you select Close all, the Select data to import tab is removed leading to an exception when re-opening the importer.
  • the Select data to import should never be deleted. The implementation of the close method also needs to be reviewed.

@jburel
Copy link
Member

jburel commented Feb 15, 2021

  • If you select Close Others, the Select data to import tab is not removed
  • If you select Close all, the Select data to import tab is not removed but the window does not have the focus. This will be confusing for the user. The user needs to click on the tab to bring the UI back

Screenshot 2021-02-15 at 10 13 41

@jburel
Copy link
Member

jburel commented Feb 16, 2021

The problem reported above #195 (comment) is now fixed.
Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImporterUI: IndexOutOfBoundsException
2 participants