Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure component is showing #290

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Make sure component is showing #290

merged 1 commit into from
Apr 14, 2022

Conversation

dominikl
Copy link
Member

I don't know how to replicate #274 but this PR should prevent it.

@jburel
Copy link
Member

jburel commented Apr 13, 2022

Code change makes sense.
Did you review other occurrences of dialog popping up?

@dominikl
Copy link
Member Author

No. Can have a look if there are other similar places which might have the same issue.

@dominikl
Copy link
Member Author

There are actually a lot of locations where JPopupMenu.show(component, ...) is called (~30 places), but none except this one seems to be a problem.

@jburel
Copy link
Member

jburel commented Apr 14, 2022

Thanks for checking

@jburel jburel merged commit 3b15c66 into ome:master Apr 14, 2022
@dominikl dominikl mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikl @jburel