Add logic to retrieve omero.qa.feedback property server-side #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not null, generate feedback URLs and bind them to the TOKEN_URL and PROCESSING_URL lookup names
jburel
reviewed
Nov 24, 2022
src/main/java/org/openmicroscopy/shoola/env/data/DataServicesFactory.java
Outdated
Show resolved
Hide resolved
|
@sbesson I think I figured out where the problem is coming from when switching user. |
I have a local server with my omero-common changes deployed and several test servers without the change |
|
scenario 3: set |
|
scenario 4 works as expected too |
jburel
reviewed
Nov 24, 2022
src/main/java/org/openmicroscopy/shoola/env/data/DataServicesFactory.java
Show resolved
Hide resolved
jburel
approved these changes
Nov 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to ome/omero-common#38
Similarly to the logic retrieving the maximum plane width/height from the server, this adds another post-connection step to retrieve the value of the server-side
omero.qa.feedbackproperty. If defined, it sets theLookupNames.TOKEN_URLandLookupNames.PROCESSING_URLentries which are used for sending feedback (comments and failed uploads) to the QA server. If the calls fails e.g. with aSecurityViolation, the current behavior is unchanged and the default values set incontainer.xmlshould be used.Testing should happen in different client/server scenarios:
container.xmlshould be used and the feedback should be sent to the OME QA systemcontainer.xmlshould be used and the feedback should be sent to the OME QA systemomero.qa.feedbackserver-side: the ConfigService should return the default value, the log file should indicate thatUsing URL defined server-side for feedback: http://qa.openmicroscopy.org.ukand the feedback should be sent to the OME QA systemomero.qa.feedbackset server-side tohttp://qa.openmicroscopy.org.uk: the log file should indicate thatUsing URL defined server-side for feedback: http://qa.openmicroscopy.org.ukand the feedback should be sent to the OME QA systemomero.qa.feedbackset server-side to an alternate QA system: the log file should indicate thatUsing URL defined server-side for feedback: <alternate QA endpoint>and the feedback should be sent to the alternate QA systemFor each configuration, ideally both comments (Help > Send Feedback) and failed uploads should be tested.