Reset key in registry #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
requested changes
Nov 28, 2022
| * @throws ConfigException If an error occurs while accessing the file | ||
| * or the file contents are not valid. | ||
| */ | ||
| public static void rebindFromFile(String file, Registry reg, List<String> keys) |
There was a problem hiding this comment.
Same as above, would using the same method name make the intent clearer?
src/main/java/org/openmicroscopy/shoola/env/data/DataServicesFactory.java
Outdated
Show resolved
Hide resolved
| { | ||
|
|
||
| try { | ||
| RegistryFactory.rebindFromFile(container.getConfigFileRelative(), registry, keys); |
There was a problem hiding this comment.
Should a debug level logging statement be added to the log to indicate that some keys are being reset?
sbesson
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
% tail -F ~/omero/log/omeroinsight.log | grep DataServices
2022-11-29 08:40:12,583 DEBUG [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) Using URL defined server-side for feedback: http://qa.openmicroscopy.org.uk
2022-11-29 08:40:12,583 INFO [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) Server version: 5.6.5
2022-11-29 08:40:32,584 DEBUG [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) Server error: ome.conditions.SecurityViolation - Cannot read configuration: omero.qa.feedback
2022-11-29 08:40:32,589 DEBUG [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) The following keys have been reset:/services/DEBUGGER/hostnameToken, /services/DEBUGGER/hostnameProcessing,
2022-11-29 08:40:32,589 INFO [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) Server version: 5.6.5
2022-11-29 08:41:23,759 DEBUG [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) The following keys have been reset:/services/DEBUGGER/hostnameToken, /services/DEBUGGER/hostnameProcessing,
2022-11-29 08:41:23,759 INFO [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) Server version: 5.6.5
2022-11-29 08:42:07,691 DEBUG [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) Server error: ome.conditions.SecurityViolation - Cannot read configuration: omero.qa.feedback
2022-11-29 08:42:07,694 DEBUG [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) The following keys have been reset:/services/DEBUGGER/hostnameToken, /services/DEBUGGER/hostnameProcessing,
2022-11-29 08:42:37,014 DEBUG [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) Using URL defined server-side for feedback: http://qa.openmicroscopy.org.uk
2022-11-29 08:42:37,015 INFO [ o.o.shoola.env.data.DataServicesFactory] (entQueue-0) Server version: 5.6.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ability to reset the value of specified keys in registry
To test the proposed changed.
omero.qa.feedbackconfigured.container.xmlcc @sbesson