Cache image settings #208

will-moore · 2018-09-03T13:23:17Z

See https://trello.com/c/22S56JnA/2-single-view-cache-settings

To test:

View image, edit settings:
- Channels on/off, pick channel colours / LUTS, adjust sliders
- Channels advanced settings - gamma, family etc.
- Greyscale checkbox
- Pan, rotate and zoom image
- Z and T indexes
- Z-projection
Move to a different image by clicking on thumbnail
Return to original image by clicking on thumbnail
Viewer should appear same as when you left it (same rendering settings, zoom, pan)
Try with multiple viewers. Not sure of the precise behaviour we want here but does it behave unexpectedly?

Known issues:

moving back and forwards several times between images without panning/zooming/rotating, pan/zoom/rotate gets reset.
projection doesn't get re-applied in some cases with multiple viewers.

jburel · 2018-09-13T15:17:43Z

Click on FullRange the image is updated.
Move to another Image
Go back to the first Image
The Image displayed corresponds to Full Range. but the Min/Max button is selected

jburel · 2018-09-13T15:20:41Z

We could probably cache Histogram and Interpolate

jburel · 2018-09-13T15:24:45Z

When I switch back to an image with cache settings (unsaved settings), the Save button is displayed
It should be enabled if the settings do not match the saved settings.

will-moore · 2018-09-17T11:41:45Z

@jburel The Min/Max, Full Range & Imported buttons probably shouldn't be 'radio' buttons where the last-clicked button is 'selected' since the settings don't continue to be 'Full Range' etc.
Currently the 'Min/Max' button is always selected, even if you've never set an image to Min/Max.

jburel · 2018-09-17T11:58:25Z

discussed with @will-moore
do not select any button e.g. min/max is always selected even if the window input != [min, max]

will-moore · 2018-09-17T15:41:45Z

The Min/Max, Full Range & Imported buttons aren't 'selected' now (don't show state).
Also, the cached rendering settings, greyscale and Z/T are added to Undo queue so that the Save button is enabled. This also means you can use Undo to return to the unsaved state. NB: minor issue - to reuse existing methods for 'pasting' settings, the channel settings are added to the Undo queue separately from Z/T and greyscale. So, you may need 2 clicks on Undo to return to unsaved state.

To test:

Adjust rendering settings (including Invert, LUTS, family, coefficient etc)
Adjust Z/T and greyscale
Move to another image and back again.
See that all settings are applied and that Save and Undo are enabled.
Save should work as expected. Undo will undo the channels settings first, then Z/T & greyscale.

jburel · 2018-09-18T20:04:44Z

After clicking on any of the range button e.g. Min/Max it stays "selected". I think this should not be the case

The rest works nicely.

jburel

The various console.log will need to be removed too

jburel · 2018-09-18T20:09:23Z

src/model/image_info.js

+            if (cached.projection) {
+                // Don't need to update response since Z dimension-slider
+                // will update the ol3-viewer
+                // response.projection = cached.projection;


remove commented out code

jburel · 2018-09-20T13:01:48Z

In multi-view it does not really work:

Double-click on the same image to enable multi-view
Do not synch the images
Turn off one channel for example
Select another image
The new image will be correctly displayed in the window with focus
Go back to the original settings.
It does not display the last viewed settings

will-moore · 2018-09-24T08:32:02Z

Last commit should fix the multi-view issues described above

rgozim · 2018-09-25T08:49:38Z

Latest commit solved the bug described by @jburel

pwalczysko · 2018-09-26T09:57:59Z

In multi-view, when 2 viewports of the same image are open, then

if there are two different rnd settings in each of the two viewports, then showing another image in the viewport and going back to the orginal one will have just one rnd setting "remembered" for both viewports with the same image (I think this is acceptable - I guess you can "remember" just one rnd per image, right ?)

pwalczysko · 2018-09-26T10:02:22Z

Bug:

- Projection seems to be not working too well, or the caching of it is not right

user-4, http://web-dev-merge.openmicroscopy.org/webclient/?show=image-79356

Workflow

- navigate to the image
- open it in iviewer
- change Rnd, selecting a LUT
- click on Projection button, drag the sliders to extreme max and min possible
- navigate to another image
- come back to the previous image (the one you did Projection on)
- observe disrcrepancy in what you saw before, and what you see now when you came back
- save the rnd -> observe discrepancy between thumb and full viewer (see screenshot)

pwalczysko · 2018-09-26T10:05:16Z

I think the problem #208 (comment) stems from the fact that Projection is not cached, it is not even saved after Save button is clicked. This might seem "logical" to us, but for a user: I do not see why Projection is so "special".

Edit: Oh, no, Projection IS saved. Thus, #208 (comment) is a true bug.

pwalczysko · 2018-09-26T10:39:58Z

moving back and forwards several times between images without panning/zooming/rotating, pan/zoom/rotate gets reset.

confirmed. this might be one to have a look again, but I don't think it is a blocker. It might get annoying when working with big images.

pwalczysko · 2018-09-26T10:44:39Z

In summary, three issues, #208 (comment) (just one Rnd remembered per image, maybe a valid approach), #208 (comment) (projection - there is clearly a regression bug) and #208 (comment) - maybe for improvement later in another PR - obviously a deficiency, but one with which it would be possible to live

…ommit

will-moore · 2018-09-26T23:00:19Z

Fixed the toggling of Z-projection having no effect on the image-viewer.

pwalczysko · 2018-09-27T09:22:26Z

Yes, the Z-projection problem is fixed.

I think that this is ready to merge FMPOV.

Maybe we could card the #208 (comment) ?

jburel · 2018-09-27T12:11:11Z

src/model/image_config.js

+    /**
+     * Applies the rendering settings, keeping a history of the old settings
+     *
+     * @param {Object} rdef the rendering defintion


jburel · 2018-09-27T12:11:36Z

src/model/image_config.js

+     * Applies the rendering settings, keeping a history of the old settings
+     *
+     * @param {Object} rdef the rendering defintion
+     * @param {boolean} for_pasting true if rdef supplied it for pasting of settings, false otherwise


jburel · 2018-09-28T14:52:07Z

I have recorded the comment https://trello.com/c/c3BU4L1x/63-cache-settings-follow-up
@will-moore is working on an alternative solution. Recording in case @will-moore cannot finish the alternative option so it does not get forgotten

will-moore added 8 commits September 3, 2018 14:15

Cache image settings between viewers

93777ab

Add docstrings

1396cbd

Remove console.log, add docs

5b13900

Cleanup Viewer.initialize_() to use 'this' instead of scope

efe8777

Replace 'for (var c in channels)' loop with forEach()

b2df1ce

Update model 'greyscale' in ol3-viewer from cached settings

e7f92fd

Cache resolution, rotation and centre

6f8529b

Cache Z and T sections

feba057

will-moore changed the title ~~Cache image settings between viewers~~ Cache image settings Sep 4, 2018

will-moore added 2 commits September 5, 2018 15:13

applyCachedSettings handles no channels or model

8f8a05b

Cache and apply Z-projection

65be1b4

TEMP console.logs

2f9d148

will-moore added 2 commits September 17, 2018 13:34

Don't show Min/Max, Full Range & Imported buttons 'active'

8393b3b

applyRenderingSettings() from cache to enable Save (and Undo)

ea39a4a

jburel reviewed Sep 18, 2018

View reviewed changes

will-moore added 3 commits September 19, 2018 11:15

Remove 'focussed' appearance from channel-mode buttons

111cac4

Remove commented-out code

3b9e950

Remove console.log() statements

73a5dfc

Prevent redundant or incorrect cacheImageSettings()

957a113

Remove publish = false changes from dimension-slider.js in previous c…

0cce5a4

…ommit

jburel reviewed Sep 27, 2018

View reviewed changes

Fix docstring typos

8661270

jburel merged commit 4dc3295 into ome:master Sep 28, 2018

jburel added this to the 0.6.0 milestone Nov 14, 2018

will-moore mentioned this pull request Jan 17, 2023

Mirroring support #439

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cache image settings #208

Cache image settings #208

will-moore commented Sep 3, 2018 •

edited

Loading

jburel commented Sep 13, 2018

jburel commented Sep 13, 2018

jburel commented Sep 13, 2018

will-moore commented Sep 17, 2018

jburel commented Sep 17, 2018

will-moore commented Sep 17, 2018

jburel commented Sep 18, 2018

jburel left a comment

jburel Sep 18, 2018

jburel commented Sep 20, 2018

will-moore commented Sep 24, 2018

rgozim commented Sep 25, 2018

pwalczysko commented Sep 26, 2018

pwalczysko commented Sep 26, 2018

pwalczysko commented Sep 26, 2018 •

edited

Loading

pwalczysko commented Sep 26, 2018 •

edited

Loading

pwalczysko commented Sep 26, 2018

will-moore commented Sep 26, 2018

pwalczysko commented Sep 27, 2018

jburel Sep 27, 2018

jburel Sep 27, 2018

jburel commented Sep 28, 2018

Cache image settings #208

Cache image settings #208

Conversation

will-moore commented Sep 3, 2018 • edited Loading

jburel commented Sep 13, 2018

jburel commented Sep 13, 2018

jburel commented Sep 13, 2018

will-moore commented Sep 17, 2018

jburel commented Sep 17, 2018

will-moore commented Sep 17, 2018

jburel commented Sep 18, 2018

jburel left a comment

Choose a reason for hiding this comment

jburel Sep 18, 2018

Choose a reason for hiding this comment

jburel commented Sep 20, 2018

will-moore commented Sep 24, 2018

rgozim commented Sep 25, 2018

pwalczysko commented Sep 26, 2018

pwalczysko commented Sep 26, 2018

pwalczysko commented Sep 26, 2018 • edited Loading

pwalczysko commented Sep 26, 2018 • edited Loading

pwalczysko commented Sep 26, 2018

will-moore commented Sep 26, 2018

pwalczysko commented Sep 27, 2018

jburel Sep 27, 2018

Choose a reason for hiding this comment

jburel Sep 27, 2018

Choose a reason for hiding this comment

jburel commented Sep 28, 2018

will-moore commented Sep 3, 2018 •

edited

Loading

pwalczysko commented Sep 26, 2018 •

edited

Loading

pwalczysko commented Sep 26, 2018 •

edited

Loading