config_parser: further futurize #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Nov 27, 2019
There was a problem hiding this comment.
With this PR, bin/omero config parse --rst now goes beyond the initial sort error but fails with some encoding error.
In my local test, this was caused by the Unicode characters in https://github.com/ome/omero-web/blob/v5.6.dev6/omeroweb/settings.py#L591. As discussed with @joshmoore, we might want to have some unit test in place either here and/or in omero-web covering the encoding use case.
will-moore
reviewed
Nov 29, 2019
| @@ -372,8 +372,8 @@ def headers(self): | |||
| additional_headers[section] = Header(section) | |||
| headers.setdefault(additional_headers[section], []).append(x) | |||
|
|
|||
| for key in headers.keys(): | |||
| headers[key].sort(lambda a, b: cmp(a.key, b.key)) | |||
| for key in list(headers.keys()): | |||
There was a problem hiding this comment.
Don't need list here really?
There was a problem hiding this comment.
Hmmm.... pretty sure this is coming from the call to futurize -w -0, i.e. being overly cautious. Is it worth pushing away?
There was a problem hiding this comment.
Probably not worth the trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for work on the documentation merge build:
ome/omero-documentation#2035