Remove metadata classes extracted to omero-metadata library

[sbesson]

Fixes #22

The metadata library has been extracted to https://github.com/ome/omero-metadata during the OMERO 5.4.x line and the relevant classes deprecated in OMERO.py.

Originally, these classes were kept deprecated until they could be safely dropped in the next major release. With the extraction of this repository and the packaging, this is not really a safe option anymore as shown by the issue since both omero-py and omero-metadata will conflict to install omero/plugins/metadata.py.

--exclude

[manics]

I guess the same applies to https://github.com/ome/omero-upload ? Any others?

[joshmoore]

I'd think so. Note: there's no requirement that a file under omero/plugins/ match the name of the command that gets registered with the CLI. Shall we change the files in ome/openmicroscopy to include _deprecated? (That is, if we don't just remove them).

[manics]

What's the advantage of renaming instead of removing? If omero-py is a compulsory dependency we can also make omero-<plugin> as compulsory/recommended, or have a omero-cli meta-package that requires omero-py and all standard decoupled plugins.

[joshmoore]

For me, that's one of the main differences between phase 1 and phase 2: if we are releasing a phase 1 version then we shouldn't delete (yet).

[snoopycrimecop]

Conflicting PR. Removed from build OMERO-python-superbuild-push#70. See the console output for more details.
Possible conflicts:

• PR Py3 (1) #19 joshmoore 'Py3 (1)'
  • src/omero/util/populate_metadata.py
  • src/omero/plugins/metadata.py

--conflicts Conflict resolved in build OMERO-python-superbuild-push#36. See the console output for more details.

[snoopycrimecop]

Conflicting PR. Removed from build OMERO-python-superbuild-push#71. See the console output for more details.
Possible conflicts:

• PR Py3 (1) #19 joshmoore 'Py3 (1)'
  • src/omero/util/populate_metadata.py
  • src/omero/plugins/metadata.py

--conflicts Conflict resolved in build OMERO-python-superbuild-push#37. See the console output for more details.

[snoopycrimecop]

Conflicting PR. Removed from build OMERO-python-superbuild-push#72. See the console output for more details.
Possible conflicts:

• PR Py3 (1) #19 joshmoore 'Py3 (1)'
  • src/omero/util/populate_metadata.py
  • src/omero/plugins/metadata.py

--conflicts Conflict resolved in build OMERO-python-superbuild-push#38. See the console output for more details.

[manics]

Since the first python 3 PR is merged how about rebase and merge this?

[joshmoore]

Discussed during the python3 call today. General thumbs up to the delete strategy with the caveats that (1) the next OMERO release may not come from master of this repository and (2) that if the tests are removed here, no other repository is currently performing a merge-merge build for testing purposes.

[sbesson]

Closing in favor of #124 which does not drop any deprecated class and investigate a more generic strategy for handling gracefully the decoupling of CLI plugins.