ometa with history #192
Closed
ometa with history #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Figure scripts tiff 10000
Split view merged 10109
Fix headers of scripts to match coding standard.
OME-TIFF Big Images 10761
Group thumbs by tag (only show each thumb once)
Fix some minor typos.
Zooming figures export
math.ceil retuns a float and so canvasHeight is a float which causes an error in PIL.
Trying to minimize the information in these files so as to reduce the amount of "drift" that can occur between this repo and possible forks.
Fix Movie_Figure script
…, add except: pass.
Remove MPI EvolBio specific blah and move link to tutorial to bottom.
Bugfixes and py3 updates
This was referenced Jan 6, 2022
Those are gone in #193
No. Only one of #191, #192 (this), or #193 should be merged. If any changes are pushed to one, the others can/should be updated. |
|
Great, #193 looks nice. #191 is broken (see my comments) but I've fixed those issues in mpievolbio-scicomp#1 which I can then open against this repo. |
|
just merged mpievolbio-scicomp#1, anything else I can do?
|
|
@will-moore : shall we close #191 and #192 then? Just let me know if you want me to rebase mpievolbio-scicomp#1 there. |
|
Closing in favor of #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at #191 but preserving the history. Steps taken:
git filter-repo --to-subdirectory-filter omero/annotation_scriptsgit merge --allow-unrelated-histories --no-ff ometa/pre-renamesince applying the individual patches withformat-patch/amdoesn't work with merge commits sadly.Note: this is likely something that we should make easier in the future.
cc: @will-moore @CFGrote @sbesson