-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test updated build with docker-compose #29
base: master
Are you sure you want to change the base?
Conversation
Beyond just using make for building a set of paired omero-web and omero-web-standalone images, this allows building within a self-contained docker-compose.yml. see: ome#28
This works on my machine, however there could be a potential build/run order issue. There is a github issue discussing how The @manics might have more to say on it. |
If the main aim is to test prebuilt merge-ci and latest-ci builds we could make it even easier for people by ensuring the containers are already built by devspace, either by
Another advantage is that you could test this using our production OMERO docker-compose.yml files by overriding the images instead of two more docker-compose.yml files for omero-web and omero-server. |
I think the main driver was to add the necessary configurability to do everything you proposed in the via the makefile in docker-compose.yml itself. In fact, I could see moving away from the makefile in favor of docker-compose as the standard build mechanism. It also makes for a clear documentation of how everything is to be used.
I can definitely see having both
Yeah, I'm not overly happy with the degree of cut-n-paste that docker-compose requires in general, but I think there's still value in having these files in the repo, especially if we can get rid of the cut-n-paste in |
Note: the only thing this doesn't easily provide is a way to add more environment variables without modifying the docker-compose.yml itself. If you have ideas on how to add that customization, I'd be interested. |
I'm still not convinced of the benefit of having a docker-compose.yml file in this repo, but if we're going ahead with it can you look into the potential ordering issue: #29 (comment) ? |
@manics, are you referring to https://stackoverflow.com/a/51425060/56887 ? I tried this:
but it would bump our minimum requirement:
I've not run into any ordering issues, i.e. the state of this PR has always worked for me. |
Beyond just using make for building a set of paired
omero-web and omero-web-standalone images, this allows
building within a self-contained docker-compose.yml.
see: #28
Questions:
Testing:
docker-compose up -d
cc: @manics @will-moore