Separate PluginLoggerImpl from LoggerImpl #2075
Conversation
Since all methods in LoggerImpl were checking
`if (runAsPlugin < 0) {...}` separating out the logic
into a separate class is straight-forward. The reason
for doing this, however, is that in the case that the
IJ plugin is used with the `loci_tools.jar` jar, which
contains log4j, then the client hangs at
"Loading Logger Service"
|
@joshmoore: good idea |
|
@joshmoore: only concern now (I did not think about it at first) is that when insight is run as a knime node, there will be no logging at all. |
|
@jburel : is there anything you want me to try to change for 5.0.0? Do we need a ticket for 5.0.1? |
|
@joshmoore: I will probably leave it as it is for 5.0.0. I think we have a ticket for passing "external" log. I will check. |
|
|
|
Pushed. |
|
The code looks fine and the latest commit is inoffensive. Does that suffice? Unfortunately I don't seem to be able to actually run Insight from ImageJ at the moment -- see #2074 (comment) |
|
@mtbc: yup, think that's fine. Thanks. |
Separate PluginLoggerImpl from LoggerImpl
|
Great. (-: I did finally get Insight running in ImageJ and it wasn't obviously horribly broken! |
|
--no-rebase |
Since all methods in LoggerImpl were checking
if (runAsPlugin < 0) {...}separating out the logicinto a separate class is straight-forward. The reason
for doing this, however, is that in the case that the
IJ plugin is used with the
loci_tools.jarjar, whichcontains log4j, then the client hangs at
--depends-on ome/bioformats#889
--depends-on #2074