Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in 5.2-to-5.3 upgrade, schedule wells for reindexing #5170

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented Mar 10, 2017

What this PR does

Adjusts the to-OMERO5.3__0 upgrade scripts to have the server reindex the existing wells after startup.

Testing this PR

From both OMERO 5.2 and some development patch release of OMERO 5.3,

  1. Import a plate and annotate some wells.

  2. In psql substitute the plate's ID into the below query and note the action counts,

 SELECT action, COUNT(entityid) FROM eventlog
    WHERE entitytype = 'ome.model.screen.Well'
    AND entityid IN (SELECT id FROM well WHERE plate = 12345)
    GROUP BY action;
  1. Upgrade to DEV-merge OMERO 5.3 and restart the server.

  2. Run the psql query again and observe that the REINDEX count is increased by the number of wells in the plate.

  3. Observe that the previously annotated wells now appear as search results.

Related reading

https://trello.com/c/tuktfBvg/310-fulltext-index-all-wells

@jburel jburel added the develop label Mar 10, 2017
@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-DEV-merge-push#615. See the console output for more details.
Possible conflicts:

  • Conflict detection failed
    • None

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-DEV-merge-push#616. See the console output for more details.
Possible conflicts:

  • Conflict detection failed
    • None

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-DEV-merge-push#617. See the console output for more details.
Possible conflicts:

  • Conflict detection failed
    • None

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-DEV-merge-push#618. See the console output for more details.
Possible conflicts:

  • Conflict detection failed
    • None

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-DEV-merge-push#619. See the console output for more details.
Possible conflicts:

  • Conflict detection failed
    • None

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-DEV-merge-push#620. See the console output for more details.
Possible conflicts:

  • Conflict detection failed
    • None

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-DEV-merge-push#621. See the console output for more details.
Possible conflicts:

  • Conflict detection failed
    • None

@mtbc
Copy link
Member Author

mtbc commented Mar 13, 2017

I have no idea what the problem is here.

@joshmoore
Copy link
Member

Likely the use of unicode: ome/scc#188

@mtbc mtbc changed the title in 5.2 → 5.3 upgrade, schedule wells for reindexing in 5.2-to-5.3 upgrade, schedule wells for reindexing Mar 13, 2017
@jburel
Copy link
Member

jburel commented Mar 13, 2017

  • Started a 5.2.7 server
  • Imported a plate
  • Annotated a well using CLI tools
  • Result of query
action  | count 
---------+-------
INSERT  |   384
REINDEX |     1
(2 rows)
  • Upgraded to 5.3
  • Restarted server
  • Result of query
 action  | count 
---------+-------
 INSERT  |   384
 REINDEX |   385

I will retest tomorrow with the merge build.

@jburel
Copy link
Member

jburel commented Mar 14, 2017

Retested today with the merge build
everything works as expected

@jburel jburel merged commit 48e1140 into ome:develop Mar 14, 2017
@mtbc mtbc deleted the reindex-wells branch March 14, 2017 10:42
@jburel jburel added this to the 5.3.0 milestone Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants