-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple python #6100
Decouple python #6100
Conversation
My notes on using this branch:
UPDATE: |
Thanks for testing a omero-marshal fix, @will-moore. I went ahead and opened a PR using |
9dc5a9d
to
4d1e55e
Compare
Ant's `untar` task unpacked *some* files at the root level. Unix's `tar xzvf` did *not*. Using zip to be on the safe side.
Maybe also delete https://github.com/joshmoore/openmicroscopy/tree/decouple-python/etc/templates/web and move these to |
They do already exist at https://github.com/ome/omero-web/tree/master/templates but you're right they need deleting. I'll push a commit which copies them to the right location in |
Ah - I realise that the |
Good catch. Should definitely also be migrated. |
Waiting on a few minor reviews from @sbesson (e.g. ome/omero-gradle-plugins#11) then will merge this PR and apply the necessary devspace changes (ome/devspace#153) to |
Alright. Related PRs are all merged and changes from merge-ci have been applied to latest-ci. Merging this and re-running the latest-ci Trigger. With the Python code removed, the excluded PRs can be updated to only contain the integration test changes. I'll update #6055 to match ome/omero-web#3 as an example. Trigger runs: |
This PR removes the Python source code and unit tests from underneath tools/Omero{Py,Web,FS} in favor of downloading the decoupled code (and
lib/scripts
) either from PyPI or GitHub. The goal is to have the OMERO.server and OMERO.py zips and dockers function identically to before this PR. Additional work on the decoupled PRs should then allow ignoring the downloaded code that is in those zips in favor of apip install
ed version.The primary downside of this PR is that merge-ci will be pinned to version 5.5.1 of the decoupled software until changes are made to merge PRs on the new repositories and download that updated code.
The current intent is that the integration tests in the main repository will continue to run until a job can be created to run the separated tests.
cc: @ome/python