Add logic to filter PRs based on the last commit status #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the PullRequest() constructor to build from github.PullRequest - Modify the PullRequest() object creation across the code - Add get_issue() method to retrieve the issue associated to the PR - Add get_last_commit() method to retrieve the head commit using the sha1 - Add get_last_status() method to retrieve the last status of the last comment
This commit defines a new flag argument --check-commit-status for all commands derived from the FilteredPullRequestCommand abstract class. The find_candidates() method is updated to add an extra filtering step if this flag is passed. This commit provides the default framework to close ome#41. Extra granularity on the status filters can be implemented when necessary.
- Create new branch/PR for each test - Add isMerged() method to TestMerged - Combine remote tests
|
Testing on looks good, but I do wonder if we don't need a section here for the status-excluded PRs as with the conflict-excluded PRs. Would that be possible? |
Also add the returned log to the info log generated by the `scc merge` and `scc set-commit-status` commands
|
With the latest commit, |
|
Does |
|
Yes with |
|
Gotcha. Generally looks good then. |
This commit should allow the testStatus to pass for any user. Since the commit is retrieved from the head repo, the authenticated user should have permissions to set the status on the commit.
certainly looks good. SCC isn't self-omitting non-checked status PRs, but otherwise ... 😏 Merging. |
joshmoore
added a commit
that referenced
this pull request
Sep 27, 2013
Add logic to filter PRs based on the last commit status
This was referenced Oct 2, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some logic to filter PRs by status namely
scc merge <branch> --check-commit-statusexcludes PRs which status attached to the last commit is not strictlysuccesstestStatusis added toTestMergewhere a PR is opene, its status is modified (none, pending, failure and success) and the outcome ofscc merge --check-commit-statusis checked for each statusAs part of these changes, the following changes have been brought:
PullRequestobject inscc.pyhas been refactored and minimally acts as a wrapper of the github.PullRequest object. New methods have been added to retrieve the corresponding issue, last commit and last status. The construction changes have been applied to the rest of the codeTestMergeintegration tests have been rewritte: a new PR is created for each test and the outcome of thescc mergecommand is systematically checked for each testtest/unitandtest/integration. At the moment only unit tests are run by the Travis build (dropping all the Github part) and the entire test suite is expected to be run under hudson./cc @mtbc, @joshmoore
Immediate build candidates for applying these changes once merged are the documentation builds where the Travis output is very reliable.