Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log message improvements #182

Merged
merged 3 commits into from
Jul 23, 2014
Merged

Log message improvements #182

merged 3 commits into from
Jul 23, 2014

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jul 16, 2014

Merge command RFEs by @joshmoore

@joshmoore
Copy link
Member

Makes sense to me. Guess there's not an generated commit pre-merge to review?

@sbesson
Copy link
Member Author

sbesson commented Jul 17, 2014

Definitely ome/snoopys-sandbox#8196 for the Previously merged. Will check if we have a merge commit pushed somewhere by integration tests.

@joshmoore
Copy link
Member

That certainly looks ok to me: 👍

@sbesson
Copy link
Member Author

sbesson commented Jul 18, 2014

Another suggestion from @joshmoore to be added to this log PR:

Conflicting PRs (not included):
 # PR 2825 dominikl 'Fixed a bug, big image preview caused Insight to freeze'

might should just be:

Excluded PRs:
 # PR 2825 dominikl 'Fixed a bug, big image preview caused Insight to freeze' (CONFLICT)

@sbesson
Copy link
Member Author

sbesson commented Jul 23, 2014

NB: I would certainly handle the last comment as a separate PR since it necessitates a fair amount of refactoring.

@joshmoore
Copy link
Member

np. Merge at will.

sbesson added a commit that referenced this pull request Jul 23, 2014
@sbesson sbesson merged commit 0dde064 into ome:master Jul 23, 2014
@sbesson sbesson deleted the log_message_rfes branch July 23, 2014 12:24
@sbesson sbesson added this to the 0.6.3 milestone Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants