Improve unicode handling when listing excluded PRs #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #188 (comment)
For PR which titles contains Unicode (as the ones truncated by GitHub from long commit headers), the formatting of the exclusion PRs in the log was causing UnicodeDecodeError.
No integration tests added yet. However this could be functionally tested as follows.
From a repository with open PRs containing Unicode characters in their title, force the PR(s) to be excluded and check the current version of
scc merge
is throwing an error, e.g. using the current state of https://github.com/IDR/idr-metadata, the following command should failWith this PR included, the same command should complete and list the excluded PRs.