Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle organization PRs #44

Merged
merged 1 commit into from
Jan 14, 2013
Merged

Handle organization PRs #44

merged 1 commit into from
Jan 14, 2013

Conversation

joshmoore
Copy link
Member

ome/omero-documentation#204 came from an organization and so
pull.head.user was None. Now using pull.head.repo if that's the case, though
it might be possible to use that in all cases.

ome/omero-documentation#204 came from an
organization and so pull.head.user was None. Now
using pull.head.repo if that's the case, though
it might be possible to use that in all cases.
@joshmoore
Copy link
Member Author

Verified with http://hudson.openmicroscopy.org.uk/job/SCC-merge/105/console

@sbesson, comments still welcome but I'm going to merge so that the daily jobs can proceed.

joshmoore added a commit that referenced this pull request Jan 14, 2013
@joshmoore joshmoore merged commit 3f28aca into ome:master Jan 14, 2013
@sbesson
Copy link
Member

sbesson commented Jan 14, 2013

@joshmoore: +1.
Documentation on the head attribute of PullRequest is not very clear/easy to find. I think we should always use pull.{head,base].repo to get head/base attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants