Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help replacement suggestions #401

Merged
merged 46 commits into from
Aug 11, 2020
Merged

Conversation

pwalczysko
Copy link
Member

This PR is on top of #396

The suggestions from the comments on #396 are implemented here.

Namely:

Happy to open this PR against your branch @jburel later, opening this as a separate PR now so that we can see the effects on snoopy.

@jburel
Copy link
Member

jburel commented Aug 3, 2020

happy to close #396 and keep this PR

@jburel
Copy link
Member

jburel commented Aug 4, 2020

@pwalczysko looks better

_includes/footer.html Outdated Show resolved Hide resolved
@will-moore
Copy link
Member

All seems fine. Tested a few links (not all) and they look good.

@pwalczysko pwalczysko mentioned this pull request Aug 6, 2020
@jburel
Copy link
Member

jburel commented Aug 7, 2020

@pwalczysko the new "analyse" for 3rd party tool icon: It will be better if the histogram/magnifying glass was centered
see
Screenshot 2020-08-07 at 09 27 53

@will-moore
Copy link
Member

Not due to this PR, but it seems that the gap between the text and buttons is too large:

Screenshot 2020-08-07 at 09 46 07

This is due to css:

.omero-feature-container.tall-content > p {
    min-height: 80px;
}

Could you try removing all the tall-content classes from the analyze page?
The other pages that use this are the sibling pages: import/, publish/, utility/ and view/.
But since this is not related to this PR, it could be handled later.

@pwalczysko
Copy link
Member Author

@will-moore I have made the change you suggest locally (removal of all tall-content from all the pages you mention (basically, all what there is of that on the www). This made the space between buttons and text smaller and nicer as you expected. But, the price we pay is an uneven button row, as some texts are 3-liners, some just 2-liners, see screenshots below
Berfore:

Screen Shot 2020-08-07 at 11 06 57

Now

Screen Shot 2020-08-07 at 11 04 02

@pwalczysko
Copy link
Member Author

@will-moore I think I have it sorted in f802668 - seems like a good compromise - no long text buttons, no 4-line blurbs, but for that, all buttons in the same row now and the gap is not too large. See what you think

@will-moore
Copy link
Member

Built locally... looks good 👍

@pwalczysko
Copy link
Member Author

The comment #401 (comment) is fixed in e046377

Rebuilt the snoopy too. See https://snoopycrimecop.github.io/www.openmicroscopy.org/omero/features/analyze/ and the sister pages and downloads.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. A few comments with the primary suggestion being to clean up our custom png files if we are definitely switching to the svg versions instead.

In addition to promoting the OMERO guides from the main website, a secondary advantage of this linking is that the HTML proofer will flag potential broken links.

bio-formats/downloads/index.html Show resolved Hide resolved
bio-formats/downloads/index.html Show resolved Hide resolved
omero/downloads/index.html Show resolved Hide resolved
omero/downloads/index.html Show resolved Hide resolved
omero/downloads/index.html Show resolved Hide resolved
omero/downloads/index.html Show resolved Hide resolved
omero/features/analyze/index.html Outdated Show resolved Hide resolved
@pwalczysko
Copy link
Member Author

@sbesson
Copy link
Member

sbesson commented Aug 11, 2020

Looks good thanks.

The only inconsistency I can spot now is https://snoopycrimecop.github.io/www.openmicroscopy.org/explore/ which uses a mixture of http://qa.openmicroscopy.org.uk/registry/demo_account/ and https://demo.openmicroscopy.org/signup/ for the signup link/button. This brings us back to the discussion started in ome/ome-help#334 (comment) for the complete resolution. I'd still vote for using http://qa.openmicroscopy.org.uk/registry/demo_account/ as the intermediate page at the expense of the extra click (www explore -> qa demo_acount -> demo sign up) until the SLA is migrated as suggested in the thread above.

Apart from this issue, given that help now redirects, I am inclined to get this deployed asap.

@pwalczysko
Copy link
Member Author

I'd still vote for using http://qa.openmicroscopy.org.uk/registry/demo_account/ as the intermediate page at the expense of the extra click

Fixed in 7903192 - this whole section might need a bit of rearrangement, but possibly this is a good compromise.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Agreed the demo sign-up workflow needs more attention. I would say that at the very least this PR reduces the number of potential entrypoints from 4 (www + qa + help + demo) to 3 (www + qa + demo) so it's an incremental improvement.

@pwalczysko
Copy link
Member Author

Built on https://snoopycrimecop.github.io/www.openmicroscopy.org/explore/

Should I merge and deploy cc @jburel ?

@jburel
Copy link
Member

jburel commented Aug 11, 2020

It looks good. gfi

@pwalczysko pwalczysko merged commit b24b845 into ome:master Aug 11, 2020
@pwalczysko pwalczysko deleted the help-repl-suggest branch August 11, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants