-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help replacement suggestions #401
Conversation
Co-authored-by: Mark Carroll <m.t.b.carroll@dundee.ac.uk>
happy to close #396 and keep this PR |
@pwalczysko looks better |
All seems fine. Tested a few links (not all) and they look good. |
@pwalczysko the new "analyse" for 3rd party tool icon: It will be better if the histogram/magnifying glass was centered |
Not due to this PR, but it seems that the gap between the text and buttons is too large: This is due to css:
Could you try removing all the |
@will-moore I have made the change you suggest locally (removal of all Now |
@will-moore I think I have it sorted in f802668 - seems like a good compromise - no long text buttons, no 4-line blurbs, but for that, all buttons in the same row now and the gap is not too large. See what you think |
Built locally... looks good 👍 |
The comment #401 (comment) is fixed in e046377 Rebuilt the snoopy too. See https://snoopycrimecop.github.io/www.openmicroscopy.org/omero/features/analyze/ and the sister pages and downloads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. A few comments with the primary suggestion being to clean up our custom png files if we are definitely switching to the svg versions instead.
In addition to promoting the OMERO guides from the main website, a secondary advantage of this linking is that the HTML proofer will flag potential broken links.
Fixes pushed and deployed on https://snoopycrimecop.github.io/www.openmicroscopy.org/omero/features/analyze/ |
Looks good thanks. The only inconsistency I can spot now is https://snoopycrimecop.github.io/www.openmicroscopy.org/explore/ which uses a mixture of http://qa.openmicroscopy.org.uk/registry/demo_account/ and https://demo.openmicroscopy.org/signup/ for the signup link/button. This brings us back to the discussion started in ome/ome-help#334 (comment) for the complete resolution. I'd still vote for using http://qa.openmicroscopy.org.uk/registry/demo_account/ as the intermediate page at the expense of the extra click (www explore -> qa demo_acount -> demo sign up) until the SLA is migrated as suggested in the thread above. Apart from this issue, given that help now redirects, I am inclined to get this deployed asap. |
Fixed in 7903192 - this whole section might need a bit of rearrangement, but possibly this is a good compromise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Agreed the demo sign-up workflow needs more attention. I would say that at the very least this PR reduces the number of potential entrypoints from 4 (www + qa + help + demo) to 3 (www + qa + demo) so it's an incremental improvement.
Built on https://snoopycrimecop.github.io/www.openmicroscopy.org/explore/ Should I merge and deploy cc @jburel ? |
It looks good. gfi |
This PR is on top of #396
The suggestions from the comments on #396 are implemented here.
Namely:
Happy to open this PR against your branch @jburel later, opening this as a separate PR now so that we can see the effects on snoopy.