Update metricfunc to provide misbehaving subscriber data to promethues #148
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>
Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>
gab-arrobo
requested changes
May 9, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the metricfunc module to provide misbehaving subscriber data to Prometheus. It introduces a new Prometheus metric for violator subscribers, registers it, and adds functions for pushing and deleting violator subscriber data, with the controller updated accordingly to report state transitions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/promclient/promclient.go | Introduces a new metric (violSub) and associated functions for metric updates. |
| controller/controller.go | Integrates the new Prometheus calls handling subscriber state changes. |
Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>
gab-arrobo
requested changes
May 13, 2025
Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>
Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metricfunc will collect misbehaving subscribers from UPF (only if closed_loop functionality enabled, by default its disabled) and remove the subscriber from the network automatically. However these removed subscribers data will not be available for prometheus. As part of this PR we update the metricfunc to provide the details to prometheus.