You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noticed that $defaults['link_attr']and $defaults['list_attr'] aren't used anywhere in the function, unless I'm overlooking it.
I think the attributes for these various tags could be added much easier using the existing, and quite handy, tag_attributes function used in other functions.
This would also be another great function to use a partial for outputting the HTML, one that would take the partial as an argument so you could the same function in multiple places but output the HTML differently.
Looks like the second param to
browse_sort_links
is an empty array, and the function splices in some defaults:$defaults = array( 'link_tag' => 'li', 'list_tag' => 'ul', 'link_attr' => '', 'list_attr' => '' );
`
But in practice, it looks like these are more working defaults in admin side:
array('link_tag' => 'th scope="col"', 'list_tag' => '')
At least on admin side, maybe making those the defaults would be easier for devs?
I'm not sure of consequences on public side yet.
The text was updated successfully, but these errors were encountered: