Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new thumbnail type option across themes. #770

Closed
kimisgold opened this issue Dec 12, 2016 · 10 comments
Closed

Test new thumbnail type option across themes. #770

kimisgold opened this issue Dec 12, 2016 · 10 comments
Assignees
Labels

Comments

@kimisgold
Copy link
Member

Under Appearance > Settings > Display Settings, there is an option to "Use Square Thumbnails". This should effect all thumbnails for exhibits, items, and collections across themes. All themes and ExhibitBuilder have been updated to reflect this change, so please pull the most recent versions when testing.

Views to check:

  • Homepage (featured item, collection, exhibit and recent items)
  • Browse views
  • Show views

(#724)

@alyssafahringer
Copy link

I've tested all of the above themes across Safari, Firefox, and Chrome. In all three browsers, the seasons, minimalist, and emiglio themes do not display thumbnail images in the show view. Instead, they appear as such:
seasons
(This is on Megan's Very Large Sandbox)

@zerocrates
Copy link
Member

Those themes appear to manually specify that images should be shown as "fullsize" on the items show page. This change is only intended to affect places where the themes currently use thumbnails, so there should be (and appears to be) no change here.

Whether what this setting does is clear from its name and description is a valid question though.

@zerocrates
Copy link
Member

Also, even for those themes that use fullsize there, turning on the Item File Gallery option in the theme settings should cause thumbnails to be used, and therefore for the square/non-square setting to have an effect.

@alyssafahringer
Copy link

Thank you for the explanation - the thumbnail type options works across all themes then. I played around with the item file gallery option and when selected, the files do display as thumbnails.

@zerocrates
Copy link
Member

To clarify: when you have the "gallery" selected, does the square/non-square checkbox actually affect that gallery? It shouldn't (i.e., the thumbnails there should be locked to square) because that hasn't been changed.

Does that align with how you'd expect the square/non-square checkbox to work?

@alyssafahringer
Copy link

So I'm either not understanding your question, or I am confused as to how the item file gallery is meant to work. When selected, multiple files for one item (I'm referring to this item) display as thumbnails:

screen shot 2016-12-13 at 15 01 20

When the box is left unchecked, the files display like this:

screen shot 2016-12-13 at 15 00 36

Apologies for being dense.

@zerocrates
Copy link
Member

My comments aren't about the gallery checkbox (in the theme settings), they're about the Use Square Thumbnails checkbox (in the appearance settings).

When you have the gallery enabled, the files display as thumbnails, but always as square thumbnails. In other words, in this specific place, the Use Square Thumbnails checkbox doesn't have any effect. My question is: is that expected/confusing/annoying/fine?

@mebrett
Copy link

mebrett commented Dec 13, 2016

It is a little odd that the gallery always uses square thumbnails (and we might change the prompt text to "item files as a grid of square thumbnails and icons" to make that clear).

What's potentially confusing is having these two settings, which seem to have similar functions, in two different locations.

@alyssafahringer
Copy link

I agree, @mebrett.

kimisgold added a commit to omeka/theme-thanksroy that referenced this issue Dec 13, 2016
kimisgold added a commit to omeka/theme-emiglio that referenced this issue Dec 13, 2016
kimisgold added a commit to omeka/theme-minimalist that referenced this issue Dec 13, 2016
kimisgold added a commit to omeka/theme-seasons that referenced this issue Dec 13, 2016
@kimisgold
Copy link
Member Author

The item gallery option description now reads: "Check this box if you wish to display your item files as a grid of square thumbnails and icons." Themes currently using this option are Thanks Roy, Emiglio, Minimalist, and Seasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants