This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Surround Transfer retrieval after insert with transaction #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Dnzt
force-pushed
the
T347-insert-load-fail
branch
2 times, most recently
from
506cedb
to
a935730
Compare
unnawut
reviewed
May 29, 2018
| |> changeset(attrs) | ||
| |> do_insert(opts) | ||
| |> case do | ||
| {_, res} -> res |
There was a problem hiding this comment.
Would the new return types cause problem? E.g. before, it would return {:ok, result} or changeset. Now it's {:ok, result} or {:error, changeset}?
There was a problem hiding this comment.
insert actually returns {:error, changeset}, here it's just shortcuted to changeset. Insert doc
There was a problem hiding this comment.
Ah sorry changeset made me immediately thought it's returning %Ecto.Changeset{}. Ignore me.
unnawut
approved these changes
May 29, 2018
| |> changeset(attrs) | ||
| |> do_insert(opts) | ||
| |> case do | ||
| {_, res} -> res |
There was a problem hiding this comment.
Ah sorry changeset made me immediately thought it's returning %Ecto.Changeset{}. Ignore me.
T-Dnzt
force-pushed
the
T347-insert-load-fail
branch
from
a935730
to
8c026e2
Compare
T-Dnzt
force-pushed
the
T347-insert-load-fail
branch
from
8c026e2
to
6a568a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: T347
Overview
Since we have multiple nodes of the DB, there seem to be some randomly failing method in the Transfer insert flow. Basically, the retrieval after the insert fails because the record was "potentially" inserted in another node. This PR surrounds the insert/get flow with a transaction as an attempt to fix that.
Changes
Repo.transaction()around ininsert