This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Fix rate exchange bug #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnawut
reviewed
May 7, 2019
apps/admin_panel/assets/src/omg-exchange-rate-modal/createExchangeModal.js
Outdated
Show resolved
Hide resolved
nicholasmueller
approved these changes
May 7, 2019
There was a problem hiding this comment.
👍 while ur at it, we should also handle the edge case of really big inputs. like if someone tries to add 999,999,999 ETH for 1 OMG for example we're showing 'infinity' and will show 1 ETH = [object Object] OMG on the other side. maybe we set a max possible value on the input?
apps/admin_panel/assets/src/omg-exchange-rate-modal/createExchangeModal.js
Outdated
Show resolved
Hide resolved
|
@nicholasmueller fixed both problem |
nicholasmueller
approved these changes
May 9, 2019
jarindr
added a commit
that referenced
this pull request
May 13, 2019
* Minor bug fix (#970) * fix missing admin * no wrap row for fromto * remove divider * add color link * fix test * Update admin email (#966) * call right endpoint * split email avatar actions, seperate reducer for alert * verify email call on redirect * verifyemail action tests * remove log, new redirect url * QC 1.2 (#976) * standardize buttons * section titles * allow disable hover effect and fix admin key table * breadcruymb and refine input * modal tweaks, end page 4 of review * dropdown tweaks * consistency for buttons * reorder table, add suffix to config and remove native spinner * ability to cancel changes in config pages and restore original state * highlight selected row when activity tab open * transaction request page clean * cancel edit profile and clean * render create exchange pair if many tokens * breadcrumb to userdetail * unify none state to - in tables * handle disabled state on select * css tweaks and new export layout * seperate time out * new exported range table * tweaks and conditional breadcrumb * remove divider * account name bug * rounding * a not so configurable css tooltip * cleaner conditional * remove selectedrow state * tweak select disabled * fix edit account * Handles incorrect non-list inputs for filters (#978) * Fix exception raised when the given `start_by` field is not allowed (#986) * Fix exception when the given pagination field is not allowed * Fix exception when non-existing field name is provided * Fix rate exchange bug (#984) * fix rate bug * fix topbar height bug * remove more flex * add max length for input * fix icon * fix width * add max amount for input * add props for input * remove prefix * remove log * fix object * bring back animation * finally fix decimal problem * fix formatter * !!!! * fix test * to number of rate * change length * fix audit package * rename admin panel to frontend (#997) * rename to frontend * test rename * fix flex bug (#1003) * fix conflict
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #980
Overview
When creating rate, the amount is not passed correctly because it divided a string
x,xxx/y,yyy.Changes
Impact
Deploy as usual