Fix argcomplete not working when type and choices given

CHANGELOG.rst

@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
 paths are considered internals and can change in minor and patch releases.
 
 
+v4.27.4 (2024-01-??)
+--------------------
+
+Fixed
+^^^^^
+- ``argcomplete`` not working when type and choices given (`#442
+  <https://github.com/omni-us/jsonargparse/issues/442>`__).
+
+
 v4.27.3 (2024-01-26)
 --------------------
 

jsonargparse/_typehints.py

@@ -568,7 +568,9 @@ def extra_help(self):
 
     def completer(self, prefix, **kwargs):
         """Used by argcomplete, validates value and shows expected type."""
-        if self._typehint == bool:
+        if self.choices:
+            return [str(c) for c in self.choices]
+        elif self._typehint == bool:
             return ["true", "false"]
         elif is_optional(self._typehint, bool):
             return ["true", "false", "null"]

jsonargparse_tests/test_argcomplete.py

@@ -175,6 +175,13 @@ class EnumType(Enum):
     assert err == ""
 
 
+def test_str_with_choices(parser):
+    parser.add_argument("--str", type=str, choices=["xyz", "abc"])
+    out, err = complete_line(parser, "tool.py --str=")
+    assert out == "xyz\x0babc"
+    assert err == ""
+
+
 @skip_if_not_cpython
 @skip_if_jsonschema_unavailable
 def test_action_jsonschema(parser):