-
-
Notifications
You must be signed in to change notification settings - Fork 59
Fix inference of required keys in TypedDicts #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You may note that this can be considered either a bug fix or the addition of a new feature. I've added changelog entries for both; please let me know your preference. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 6439 6462 +23
=========================================
+ Hits 6439 6462 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mauvilsa It is actually ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking good!
Please extend DOCUMENTATION.rst#L403-L405 to mention the support for NotRequired
and Required
.
Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>
Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>
|
What does this PR do?
This PR fixes inference of required and missing keys in
TypedDict
s.Closes #570
Before submitting