Skip to content

Conversation

a-gardner1
Copy link
Contributor

@a-gardner1 a-gardner1 commented Oct 14, 2024

What does this PR do?

Resolves #596.

Note that this cannot be addressed in Python 3.8 or below (see the linked context in the issue).

Before submitting

  • Did you read the contributing guideline?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2160982) to head (7f0c0f3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #597   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         6488      6492    +4     
=========================================
+ Hits          6488      6492    +4     
Flag Coverage Δ
py3.10 85.76% <80.00%> (-0.03%) ⬇️
py3.10_all 98.79% <80.00%> (-0.05%) ⬇️
py3.10_pydantic1 49.15% <0.00%> (-0.04%) ⬇️
py3.10_pydantic2 48.93% <0.00%> (-0.04%) ⬇️
py3.10_types 98.81% <80.00%> (-0.05%) ⬇️
py3.11 85.95% <80.00%> (-0.03%) ⬇️
py3.11_all 98.75% <80.00%> (-0.05%) ⬇️
py3.11_types 98.76% <80.00%> (-0.05%) ⬇️
py3.12 86.09% <80.00%> (-0.04%) ⬇️
py3.12_all 98.75% <80.00%> (-0.05%) ⬇️
py3.12_types 98.76% <80.00%> (-0.05%) ⬇️
py3.8 86.38% <40.00%> (-0.04%) ⬇️
py3.8_all 99.42% <40.00%> (-0.05%) ⬇️
py3.8_types 99.46% <40.00%> (-0.05%) ⬇️
py3.9 86.31% <80.00%> (-0.03%) ⬇️
py3.9_all 99.38% <80.00%> (-0.05%) ⬇️
py3.9_types 99.39% <80.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-gardner1 a-gardner1 marked this pull request as ready for review October 14, 2024 19:53
Copy link
Member

@mauvilsa mauvilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link

@mauvilsa mauvilsa merged commit 9612361 into omni-us:main Oct 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Totality of inherited TypedDict keys is not respected
2 participants