Fix hyphen parser with default #736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing: #731
Using dashes (or hyphens) is sometimes more common and
jsonargparse
supports this (see #301). However, when resolving default values for arguments in a nested dataclass, it does not normalize arguments with underscores, which results inNSKeyError
(see the issue).This PR adds the normalization line
dest = dest.replace("-", "_")
that resolves the problem.Before submitting