AuthZ for Payment Tiers #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coopbri
approved these changes
Apr 17, 2025
coopbri
reviewed
Apr 23, 2025
benjamin-parks
approved these changes
Apr 23, 2025
Twonarly1
reviewed
Apr 24, 2025
| await db.update(users).set({ tier }).where(eq(users.hidraId, hidraId)); | ||
|
|
||
| console.log( | ||
| `${tier.toUpperCase()} Subscription Tier set for User: ${hidraId}`, |
There was a problem hiding this comment.
bunch of console logs in this file that may leak Id's. If this isn't a problem, disregard.
There was a problem hiding this comment.
Well, this is all on the server, so doesn't leak to the public. But ofc can always remove logging! hidraId I feel like is fine to display in logs here. Going to move forward and get this merged as is, but will tag @coopbri here for visibility to get his thoughts as well! Happy to push a hotfix later if we want to remove the logs
Twonarly1
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task link: https://linear.app/omnidev/issue/OMNI-192/implement-authz-based-on-payment-tier
Added
tierto the graphql context through thecurrentUserobject. Updated the RBAC plugins for organizations and projects to include restrictions based on the current user's subscription.Important
Test with this App repo PR.
Test Steps
tiercolumn is not available for user mutations through the API