changed Get Started and Subscribe button color while hovering #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
omrajsharma
reviewed
May 21, 2024
client/package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "@mui/icons-material": "^5.6.2", | |||
| "@mui/material": "^5.6.2", | |||
| "next": "12.1.5", | |||
|
|
|||
server/index.js
Outdated
| @@ -17,7 +17,7 @@ app.get('/', (req, res) => { | |||
| }); | |||
|
|
|||
| // Start the server | |||
| const PORT = process.env.PORT || 8080; | |||
| const PORT = process.env.PORT || 8000; | |||
There was a problem hiding this comment.
why this change is required ?
There was a problem hiding this comment.
- actually in my system port 8080 was not working so I changed this to 8000. But no worries I will resolve this.
|
Please resolve the comments @neevgit25 |
yeah ,Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
changed Get Started and Subscribe button color while hovering
Description
Before, the color of the "Get Started" and "Subscribe" buttons did not change when hovering over them, which made them not feel like buttons.
media-
https://github.com/omrajsharma/bigohhh.com/assets/115336952/4b320652-5f85-4c81-b8a3-d726b8e414be
Fixes
AFTER CHANGES
A nice button effect is achieved by changing the background color of the Get Started and Subscribe buttons when hovering.
CHNAGED_SUBS.mp4
Get.Stated.mp4
Fixes #109
Type of PR
Checklist
I have read and followed the Contribution Guidelines.
I have tested the changes thoroughly before submitting this pull request.
I have provided relevant issue numbers, snapshots, and videos after making the changes.
I have not borrowed code without disclosing it, if applicable.
This pull request is not a Work In Progress (WIP), and only completed and tested changes are included.
I have tested these changes locally.