a bit optimize: don't needed to make Timestamp twice #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
И еще на один шажок код перестает работать под version < 5.3. Это ведь где-то уже обсуждалось что версию 5.3 и меньше мы не поддерживаем?
There was a problem hiding this comment.
Версии ниже 5.3. уже не поддерживаются самим php.
Смысл тратить усилия на совместимость со старьем? :)
Даже в нашем FAQ написано:
Q: I am using PHP4 and I...
Q: I'm using feature, which obsoleted since revision N...
A: You're doomed.
There was a problem hiding this comment.
Просто обратил внимание и пытаюсь пропомнить - обсуждалось ли где-то это нами или нет. Вроде бы было на эту тему обсуждение.
|
А так +1 |
|
+1 |
dovg
added a commit
that referenced
this pull request
Nov 18, 2011
a bit optimize: don't needed to make Timestamp twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Поможет сэкономить немного спичек. В предыдущей реализации на каждую строчку Timestamp создавался дважды.
Тесты не сломались. Вольем?