Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vagrant box reference to readme #48

Merged
merged 5 commits into from
Jan 23, 2019
Merged

Conversation

wreiske
Copy link
Contributor

@wreiske wreiske commented Jan 5, 2019

No description provided.

drbgfc and others added 4 commits September 24, 2018 16:25
Merge develop into master for 1.0.35/SITE 3.1.19 Sept2018 Release
Merge Develop into Master for Oct 2018 3.1.20 Release
Merge develop into master for SITE Nov 2018 3.1.21 Release / 1.0.36
@drbgfc
Copy link
Contributor

drbgfc commented Jan 8, 2019

Hi
This project https://github.com/mieweb/vagrant-ccda-validator/ seems pretty cool. I have to check with the ONC if there are any issues with referencing it before merging. I will try it out myself soon (I know I know this would answer the questions automatically) but first, a couple questions:
-Does it (automatically) include any vocabulary files besides the ones included in the https://github.com/siteadmin/code-validator-api repo pr are you just manually adding them after (from a current or prior set of downloads from VSAC)?
-Does it include (or download) scenarios? Is this planned in the future?

Thanks!
-Dan

@wreiske
Copy link
Contributor Author

wreiske commented Jan 8, 2019

@drbgfc it includes both the reference-ccda-validator and code-validator-api repositories as git submodules (so they will always be up to date). When the vagrant box builds, it also downloads the referenceccdaservice.war from the github release page. None of the validator resources are actually included in the vagrant github project. The vagrant up command fetches what it needs and moves files around from the respective git submodules.

You can see here what it does:
https://github.com/mieweb/vagrant-ccda-validator/blob/master/files/scripts/do-magic.sh

I believe it does include scenarios? This is a screenshot from the vagrant machine running.
image

@drbgfc
Copy link
Contributor

drbgfc commented Jan 8, 2019

Great thanks, just confirming. We would love to have a setup like this that also includes the vocabulary but we can't due to licensing issues, although there may be a way in the future to resolve that so it's cool that this work was done. So I wanted to make sure, although awesome, that that was not done to protect you. I'll inform the ONC about this and don't forsee any issues with the reference.

@drbgfc
Copy link
Contributor

drbgfc commented Jan 14, 2019

FYI: I am in discussion with the ONC on this matter

@drbgfc drbgfc changed the base branch from master to develop January 23, 2019 15:16
@drbgfc drbgfc changed the title Added vagrant box Add Vagrant box reference to readme Jan 23, 2019
@drbgfc drbgfc merged commit 60988df into onc-healthit:develop Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants