Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update static validator UI to more closely match ETT results #50

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

desai827
Copy link
Contributor

@desai827 desai827 commented Jan 14, 2019

I updated the UI for the validationui.html page to more closely resemble what is seen on the SITE validator.

Error styling updated to more closely resemble SITE UI
Added some UI styling to make the errors resemble the current SITE validator
@drbgfc
Copy link
Contributor

drbgfc commented Jan 14, 2019

Cool thanks, I'll take a look in the next few days - however - can you make this PR for develop instead of master pelase? We don't ever merge into master until a release (and only from develop).

@desai827 desai827 changed the base branch from master to develop January 15, 2019 00:12
@desai827
Copy link
Contributor Author

Done.

@drbgfc drbgfc changed the title UI Update Static validator UI Update which more closely matches ETT results Jan 23, 2019
@drbgfc drbgfc changed the title Static validator UI Update which more closely matches ETT results Update static validator UI to more closely match ETT results Jan 23, 2019
@drbgfc drbgfc merged commit 16563b4 into onc-healthit:develop Jan 23, 2019
@desai827 desai827 deleted the patch-1 branch January 28, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants