Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8 and Nette 3 #8

Open
janbarasek opened this issue Jul 11, 2021 · 3 comments
Open

Support PHP 8 and Nette 3 #8

janbarasek opened this issue Jul 11, 2021 · 3 comments

Comments

@janbarasek
Copy link

Hi!

Are you planning to add native support for PHP 8 and Nette 3 in the near future? It could be a new master version.

If you would be interested in upgrading, I can send a Pull request.

Thanks.
@ondrs
Copy link
Owner

ondrs commented Jul 16, 2021

All contributions are welcomed!
Can you please make the upgrade BC compatible? It's a very tiny library, there is no need to have a breaking change because of PHP8 and Nette3

@janbarasek
Copy link
Author

Adding data types is a BC break or not?

@ondrs
Copy link
Owner

ondrs commented Jul 16, 2021

Currently, it supports PHP 5.4 which is probably unnecessary.
We can drop support for lower versions than PHP 7.1 so types can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ondrs @janbarasek