Define ITT_ARCH_IA64 when undefined #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure why ITT_ARCH_IA64 was skipped here. This results in unsupported architecture (RISC-V, in my case) falls to the `ITT_ARCH==ITT_ARCH_IA64` branch below (because both of them are undefined) and results in a build error due to `__TBB_machine_fetchadd4` being undefined.
felixonmars
changed the title
|
@ekovanova, can you please review this patch for ITT API? |
ekovanova
approved these changes
Aug 31, 2021
alexey-katranov
approved these changes
Aug 31, 2021
|
Thanks for the patch. I've proposed the changes to ITT API repo (intel/ittapi#23). |
|
@alexey-katranov should we close or merge this patch ? |
|
We can merge. In addition, it makes sense to update ITT stuff. |
This was referenced Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why ITT_ARCH_IA64 was skipped here. This results in unsupported architecture (RISC-V, in my case) falls to the
ITT_ARCH==ITT_ARCH_IA64branch below (because both of them are undefined) and results in a build error due to__TBB_machine_fetchadd4being undefined.