Optimize search_chunks_by_priority: Skip calculate_chunk if the offset is already used #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kissgyorgy
requested changes
Nov 29, 2021
kukovecz
force-pushed
the
23-check-if-whole-chunk-is-covered
branch
from
602cd0d to
6a6c034
Compare
kukovecz
force-pushed
the
23-check-if-whole-chunk-is-covered
branch
from
6a6c034 to
79535c2
Compare
added 2 commits
November 30, 2021 13:46
This should have never been in reverse order. This bug was introduced in: e07e844
kukovecz
force-pushed
the
23-check-if-whole-chunk-is-covered
branch
from
79535c2 to
c7d1231
Compare
kukovecz
changed the title
kissgyorgy
requested changes
Nov 30, 2021
kukovecz
force-pushed
the
23-check-if-whole-chunk-is-covered
branch
2 times, most recently
from
77e372a to
4587d29
Compare
kukovecz
force-pushed
the
23-check-if-whole-chunk-is-covered
branch
from
4587d29 to
bbf4bbb
Compare
kissgyorgy
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23