Skip to content

Fix min date #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2023
Merged

Fix min date #134

merged 2 commits into from
May 17, 2023

Conversation

t0m3k
Copy link
Collaborator

@t0m3k t0m3k commented May 14, 2023

Multiple fixes:

  • minDate and maxDate setting now includes the dates provided. Before, if minDate was provided using new Date(), comparison would be made using nanoseconds. Since new Date() value was created on page load, it would be in the past, making today's date not selectable. Similar could happen on end date in some cases. Now as long as day is matching both dates will be included. Issue Selecting current day gets the previous day #117
  • ColorKey and Colors types were created for type safety. Now, users using datepicker will see types for colorPrimary based on COLORS constant. COLORS constant will also enforce all color types to be including new colors using Colors interface.

@onesine
Copy link
Owner

onesine commented May 17, 2023

Thanks for this PR @t0m3k

@onesine onesine merged commit 3a88d5f into onesine:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants