Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better DX for deploying via docker image #320

Closed
delano opened this issue Apr 26, 2024 · 0 comments · Fixed by #323
Closed

Better DX for deploying via docker image #320

delano opened this issue Apr 26, 2024 · 0 comments · Fixed by #323
Assignees
@delano
Labels
bug Issues that report bugs in the project. improvement Issues or pull requests that involve improvements to the project. ops Operational issues tech debt Addressing future rework costs due to quick, suboptimal solutions taken previously. ux Work that improve user experience, interaction patterns, or interface usability
Milestone
Ruby 3+ Support

Comments

@delano
Copy link
Collaborator

delano commented Apr 26, 2024

The new Dockerfile works great. Getting a docker container running is tedious though, with the proper configuration for the hostname, redis, etc. e.g.

  $ docker run -p 3000:3000 -d --name onetimesecret \
      -e ONETIMESECRET_REDIS_URL=$ONETIMESECRET_REDIS_URL \
      -e ONETIMESECRET_COLONEL=$ONETIMESECRET_COLONEL \
      onetimesecret/onetimesecret:next

We can improve the developer experience by standardizing the environment variables, using the most common conventions (e.g. REDIS_URL) and simplifying host settings.
@delano delano added bug Issues that report bugs in the project. improvement Issues or pull requests that involve improvements to the project. tech debt Addressing future rework costs due to quick, suboptimal solutions taken previously. ux Work that improve user experience, interaction patterns, or interface usability ops Operational issues labels Apr 26, 2024
@delano delano added this to the Ruby 3+ Support milestone Apr 26, 2024
@delano delano self-assigned this Apr 26, 2024
@github-project-automation github-project-automation bot moved this to Triage in Road to 1.0 Apr 26, 2024
@delano delano linked a pull request Apr 29, 2024 that will close this issue
[#320] Improve docker support and developer experience #323
Merged
delano added a commit that referenced this issue Apr 30, 2024
@delano
Merge pull request #323 from onetimesecret/320-better-dx-for-deployin…
51ddaa9 
…g-via-docker-image

[#320] Improve docker support and developer experience
@github-project-automation github-project-automation bot moved this from Triage to Done in Road to 1.0 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delano delano

Labels
bug Issues that report bugs in the project. improvement Issues or pull requests that involve improvements to the project. ops Operational issues tech debt Addressing future rework costs due to quick, suboptimal solutions taken previously. ux Work that improve user experience, interaction patterns, or interface usability
Projects
Road to 1.0
Status: Done
Milestone
Ruby 3+ Support
Development

Successfully merging a pull request may close this issue.

[#320] Improve docker support and developer experience onetimesecret/onetimesecret
1 participant
@delano