Skip to content

Fix first rendererd initial props with ssr #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2017
Merged

Fix first rendererd initial props with ssr #48

merged 3 commits into from
Oct 22, 2017

Conversation

oneut
Copy link
Owner

@oneut oneut commented Oct 22, 2017

Overview

  • Fix First Rendered Initial Props with ssr.
    • Delete acquisition of initial props in getFirstRenderedInitialProps
    • Support parameter firstRenderedInitialProps with Router

Refactoring

  • Delete Utils
  • Create class RouteNormalizer

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 99.615% when pulling 74b1ad5 on fix_first_rendered_initial_props_with_ssr into f7ea0a8 on master.

@oneut oneut merged commit 260eeec into master Oct 22, 2017
@oneut oneut deleted the fix_first_rendered_initial_props_with_ssr branch October 23, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oneut @coveralls