Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts flag - monotonic chain support #427

Merged
merged 8 commits into from
Jun 22, 2023

Conversation

bluesign
Copy link
Collaborator

@bluesign bluesign commented Jun 20, 2023

Closes #421

Description

Adds contract flag support to monotonic chain ( also probably other chain id's )


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@m-Peter
Copy link
Contributor

m-Peter commented Jun 21, 2023

@bluesign Thanks for the refactor 💯 I didn't realize that I had made the chain hardcoded

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

emulator/contracts.go Outdated Show resolved Hide resolved
emulator/contracts.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
@turbolent
Copy link
Member

Could we maybe add a test case ensuring we do not regress?

@m-Peter
Copy link
Contributor

m-Peter commented Jun 21, 2023

@turbolent I think that we are covered by a test case I added some days ago.

@bluesign
Copy link
Collaborator Author

I will add some tests or extend current test with simple addresses.

@turbolent
Copy link
Member

turbolent commented Jun 21, 2023

Nice! 👍

Yeah, it would be good to extend that test and run it for each chain. Currently it is only testing the "Emulator chain".

Thank you!

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for fixing this 👍

@bluesign
Copy link
Collaborator Author

Updated test to include monotonic chain ( mainnet / testnet is used with remote debugger, basically RN nodes ) so they will already have contracts deployed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #427 (c4836b7) into master (06a822e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   54.44%   54.44%           
=======================================
  Files          27       27           
  Lines        3578     3576    -2     
=======================================
- Hits         1948     1947    -1     
+ Misses       1471     1469    -2     
- Partials      159      160    +1     
Flag Coverage Δ
unittests 54.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
emulator/contracts.go 73.33% <100.00%> (-0.58%) ⬇️
server/server.go 54.47% <100.00%> (-1.17%) ⬇️

... and 1 file with indirect coverage changes

emulator/contracts_test.go Outdated Show resolved Hide resolved
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to deploy contracts when using simple (monotonic) addresses
4 participants