-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts flag - monotonic chain support #427
Conversation
@bluesign Thanks for the refactor 💯 I didn't realize that I had made the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
Could we maybe add a test case ensuring we do not regress? |
@turbolent I think that we are covered by a test case I added some days ago. |
I will add some tests or extend current test with simple addresses. |
Nice! 👍 Yeah, it would be good to extend that test and run it for each chain. Currently it is only testing the "Emulator chain". Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for fixing this 👍
Updated test to include monotonic chain ( mainnet / testnet is used with remote debugger, basically RN nodes ) so they will already have contracts deployed. |
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
=======================================
Coverage 54.44% 54.44%
=======================================
Files 27 27
Lines 3578 3576 -2
=======================================
- Hits 1948 1947 -1
+ Misses 1471 1469 -2
- Partials 159 160 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Closes #421
Description
Adds contract flag support to monotonic chain ( also probably other chain id's )
For contributor use:
master
branchFiles changed
in the GitHub PR explorer