add NFT Metadata queries #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisyphusSmiling
changed the title
Glad you came to the same conclusion, seems like for current purposes we need to use scripts as our actual tests and can't return any structs for now to any actual test cases |
austinkline
approved these changes
May 19, 2023
| let viewType: Type = Type<MetadataViews.NFTCollectionData>() | ||
|
|
||
| // Iterate over each public path | ||
| account.forEachStored(fun (path: StoragePath, type: Type): Bool { |
There was a problem hiding this comment.
My only concern here is that we might want a second script which makes sure to only return what you can actually get to. This script will return everything but that doesn't mean you can actually withdraw every nfts from every collection that comes back
I'm perfectly find with us tackling those separately though
There was a problem hiding this comment.
Very true. I figure we can leverage the code from #43 for that query
sisyphusSmiling
force-pushed
the
query-nft-metadata
branch
from
9ba9031
to
6a90a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #25
Note about tests:
I had to replace a script-defined struct with MetadataViews.NFTCollectionDisplay & create assertion scripts to validate return values against expected. This doesn't feel like a great way to write tests as it's fragile, and I'd prefer to construct comparison values from within the tests themselves. Definitely open to other ideas here.