Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to compile from source for OSX 10.10.1 #9

Closed
evandrix opened this issue Dec 15, 2014 · 14 comments
Closed

Unable to compile from source for OSX 10.10.1 #9

evandrix opened this issue Dec 15, 2014 · 14 comments
Labels

Comments

@evandrix
Copy link

The only choice was to build from source for my platform, since a binary distribution is not available (yet?).

I'm stuck at the following point after issuing make:

go clean tmsu
rm -Rf bin
rm -Rf tmsu-x86_64-0.5.0
rm -f tmsu-x86_64-0.5.0.tgz
go build -o bin/tmsu tmsu
# tmsu/common/terminal
src/tmsu/common/terminal/print.go:29: undefined: Width
src/tmsu/common/terminal/print.go:108: undefined: Width
make: *** [compile] Error 2

The offending lines are:

line #29: PrintColumnsWidth(items, Width())

line #108: PrintWrappedWidth(text, Width())

So, what should be the definition of Width() then?

Thanks

@evandrix
Copy link
Author

Nvm, solved it by symlink /src/tmsu/common/terminal/terminal.go => /src/tmsu/common/terminal/terminal_linux.go

@oniony
Copy link
Owner

oniony commented Dec 15, 2014

I think the solution is not a symlink but to rename terminal_linux.go to
terminal_unix.go. I think the reason I didn't do this is because it stopped
Windows working. I'll have to get some virtual machines up and running to
test this.

I'd be interested to know if the rename works though.

Thanks,
Paul

On Mon, 15 Dec 2014 19:21 Lee Wei Yeong notifications@github.com wrote:

Closed #9 #9.


Reply to this email directly or view it on GitHub
#9 (comment).

@oniony
Copy link
Owner

oniony commented Dec 15, 2014

Reopening until OSX support works out of the box.

@oniony oniony reopened this Dec 15, 2014
@oniony
Copy link
Owner

oniony commented Dec 15, 2014

I've checked in a change that allows the virtual filesystem to be compiled for all platforms except Windows (where I know it doesn't work) rather than Linux only. This should fix the issue on OSX.

I would appreciate it if you could please give it a test as I don't have a Mac to test this on myself.

@evandrix
Copy link
Author

sure! I'll test it when I get back from work later this evening, and let you know if it works. Thanks for the quick response...

@evandrix
Copy link
Author

mmm it does compile ie. make && make install all work just fine out of the box. I've yet to actually run the program and using it though.

@oniony
Copy link
Owner

oniony commented Dec 16, 2014

OK, many thanks. I'll close this then. Feel free to raise another issue if
you hit any problems at all.

On Tue, 16 Dec 2014 18:26 Lee Wei Yeong notifications@github.com wrote:

mmm it does compile ie. make && make install all work just fine out of
the box. I've yet to actually run the program and using it though.


Reply to this email directly or view it on GitHub
#9 (comment).

@oniony oniony closed this as completed Dec 16, 2014
@ashleyharvey
Copy link
Contributor

Thanks for this - just compiled on 10.10.1 as well by renaming terminal_linux.go to terminal_unix.go. I will be tagging and playing with this for the next few days so I'll follow up with any issues (or a thank you) either way.

@oniony
Copy link
Owner

oniony commented Dec 27, 2014

The changes I made mean it should to longer be the necessary to rename the files. Are you compiling from the master branch?

@ashleyharvey
Copy link
Contributor

I had some issue with release so I went to default - which I think is master, yes?

To compile that I had to rename that file and then it compiled fine. Minus VFS support.

Sent from my iPhone

On Dec 27, 2014, at 03:04, Paul Ruane notifications@github.com wrote:

The changes I made mean it should to longer be the necessary to rename the files. Are you compiling from the master branch?


Reply to this email directly or view it on GitHub.

@oniony
Copy link
Owner

oniony commented Dec 27, 2014

OK, thanks, I'll take a look as soon as I'm home. It could be I've missed a
file.

On Sat, 27 Dec 2014 17:21 ashleyharvey notifications@github.com wrote:

I had some issue with release so I went to default - which I think is
master, yes?

To compile that I had to rename that file and then it compiled fine. Minus
VFS support.

Sent from my iPhone

On Dec 27, 2014, at 03:04, Paul Ruane notifications@github.com wrote:

The changes I made mean it should to longer be the necessary to rename
the files. Are you compiling from the master branch?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#9 (comment).

@oniony
Copy link
Owner

oniony commented Dec 27, 2014

Actually, I've been able to check with my phone and, indeed,
terminal_linux.go no longer exists in the repository. Could it be you have
o slightly old clone from before this was fixed?

On Sat, 27 Dec 2014 17:22 Paul Ruane paul.ruane@oniony.com wrote:

OK, thanks, I'll take a look as soon as I'm home. It could be I've missed
a file.

On Sat, 27 Dec 2014 17:21 ashleyharvey notifications@github.com wrote:

I had some issue with release so I went to default - which I think is
master, yes?

To compile that I had to rename that file and then it compiled fine.
Minus VFS support.

Sent from my iPhone

On Dec 27, 2014, at 03:04, Paul Ruane notifications@github.com
wrote:

The changes I made mean it should to longer be the necessary to rename
the files. Are you compiling from the master branch?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#9 (comment).

@ashleyharvey
Copy link
Contributor

I guess it's possible! Let me remove all the files and recompile from scratch. I'll let you know how it goes.

Sent from my iPhone

On Dec 27, 2014, at 09:25, Paul Ruane notifications@github.com wrote:

Actually, I've been able to check with my phone and, indeed,
terminal_linux.go no longer exists in the repository. Could it be you have
o slightly old clone from before this was fixed?

On Sat, 27 Dec 2014 17:22 Paul Ruane paul.ruane@oniony.com wrote:

OK, thanks, I'll take a look as soon as I'm home. It could be I've missed
a file.

On Sat, 27 Dec 2014 17:21 ashleyharvey notifications@github.com wrote:

I had some issue with release so I went to default - which I think is
master, yes?

To compile that I had to rename that file and then it compiled fine.
Minus VFS support.

Sent from my iPhone

On Dec 27, 2014, at 03:04, Paul Ruane notifications@github.com
wrote:

The changes I made mean it should to longer be the necessary to rename
the files. Are you compiling from the master branch?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#9 (comment).


Reply to this email directly or view it on GitHub.

@ashleyharvey
Copy link
Contributor

Re-compiled, didn't have to rename the file. Encountering other errors, I'm going to move over to the open issue for that instead of here.

@oniony oniony added the bug label Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants