Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Closing splits with 'editor.splits.mode' === 'oni' #1703

Merged
merged 32 commits into from
Mar 13, 2018

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Mar 3, 2018

  • Fix Window reference (OniEditor vs NeovimEditor)
  • Fix commandline sticking around
  • Dispose editor

@codecov
Copy link

codecov bot commented Mar 3, 2018

Codecov Report

Merging #1703 into master will decrease coverage by 0.14%.
The diff coverage is 8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
- Coverage    42.2%   42.06%   -0.15%     
==========================================
  Files         163      163              
  Lines        6205     6231      +26     
  Branches      870      878       +8     
==========================================
+ Hits         2619     2621       +2     
- Misses       3412     3436      +24     
  Partials      174      174
Impacted Files Coverage Δ
browser/src/neovim/Session.ts 10% <0%> (-1.67%) ⬇️
browser/src/neovim/NeovimInstance.ts 5.79% <0%> (-0.13%) ⬇️
browser/src/Services/EditorManager.ts 50.79% <25%> (-2.78%) ⬇️
browser/src/UI/components/Tabs.tsx 39.58% <0%> (-0.85%) ⬇️
...src/Services/Configuration/DefaultConfiguration.ts 81.25% <0%> (ø) ⬆️
browser/src/Services/Workspace/Workspace.ts 23.15% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c389514...e40ca1a. Read the comment docs.

@bryphe bryphe changed the title [WIP] Closing splits with 'editor.splits.mode' === 'oni' Closing splits with 'editor.splits.mode' === 'oni' Mar 7, 2018
@bryphe bryphe merged commit d6aa821 into master Mar 13, 2018
@bryphe bryphe deleted the bryphe/feature/oni-splits-close-window branch March 13, 2018 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant