Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Keyboard shortcuts for window movement is broken ( Win + Right / Left Arrow) #3730

Open
bryphe opened this issue Jul 2, 2021 · 2 comments
Open

Windows: Keyboard shortcuts for window movement is broken ( Win + Right / Left Arrow) #3730

bryphe opened this issue Jul 2, 2021 · 2 comments
Labels
bug Something isn't working I-regression Regression (a bug introduced from a change / fix) platform-windows Platform: Windows U-revery Upstream: Potentially dependent on changes in revery

Comments

@bryphe
Copy link
Member

bryphe commented Jul 2, 2021

Reported on Discord: https://discord.com/channels/417774914645262338/424012160696582144/860090626878865438 ( thanks @Apostolique)

On Windows, the Win+Right / Win + Left keys don't move the window as expected. In addition, double-clicking the titlebar isn't working correctly.

This doesn't reproduce on 0.5.6, but does reproduce on latest master. Tracked down the breaking commit to the upgrade to SDL 2.0.14.0: #3624
@bryphe bryphe added platform-windows Platform: Windows bug Something isn't working U-revery Upstream: Potentially dependent on changes in revery I-regression Regression (a bug introduced from a change / fix) labels Jul 2, 2021
@PaulFlatlooker
Copy link

It might be related: on macos, keyboard shortcuts using option looks broken as well (i noticed it on july 2nd after updating onivim).

in keybindings.json:

{ "key": "<D-A-Right>", "command": "workbench.action.nextEditor", "when": "editorTextFocus" },

does not work anymore (the editor stays on the current editor)

similarly, in configuration.json:

"experimental.viml": [
"inoremap <A-Left> <ESC>bi"
]

does not work anymore (the cursor does not move when the shortcut keys are pressed)

@dhruvmittal
Copy link

Possibly related window management issues on Windows:

  • Double clicking window title doesn't maximize
  • Window snapping doesn't trigger via
    • Super+Arrows
    • Dragging to screen edges
  • Maximizing onivim covers the task bar.

Windows 10, 0.5.9-nightly

@bryphe bryphe mentioned this issue Jul 14, 2021
Merged
4 tasks
bryphe added a commit that referenced this issue Jul 22, 2021
@bryphe
feat(windows): Customizable title bar style (#3765)
0cd8c42 
__Issue:__ There are several quirks on Windows with the 'undecorated' Windows style - issues like:
- #3730 
- #3071 
- #3063 

__Fix:__ These can be deal-breakers for use as a daily editor, so until we have those fixed for the 'undecorated' Windows, change the default setting to use the native titlebar. 

This introduces a new setting - `window.titleBarStyle` that can be `"native"` or `"custom"`. The `"custom"`  titlebar looks nicer, because it is themed and custom rendered, however it has the above quirks. On Windows, change the default to `"native"`.

In addition, this pushes up the configuration loading sooner in the startup cycle, so we can pick up configuration settings like `"window.titleBarStyle"` prior to opening the window.

__Todo:__
- [x] Fix margin on Windows, based on whether we are using the decorated window or not
- [x] Test OSX
- [x] Test Windows (both settings)
- [x] Test on Linux (both settings)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working I-regression Regression (a bug introduced from a change / fix) platform-windows Platform: Windows U-revery Upstream: Potentially dependent on changes in revery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhruvmittal @bryphe @PaulFlatlooker