-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: XML Theme and Grammar support #1616
Feature: XML Theme and Grammar support #1616
Conversation
https://github.com/vscode-restructuredtext/vscode-restructuredtext fails with "invalid backref number/name". Seems like a regex issue. |
Interesting... yes, seems unrelated to the new parsing logic (unless there's some sort of weird string escaping happening). But this seems unlikely since there are tests that would cover this. Must be exposing a pre-existing bug in our regex handling. |
https://github.com/SuperiorServers/vscode-glua fails because it doesn't have a repository |
After making repository optional, that one fails with "invalid backref" too. |
I created a PR for the invalid backref problem at onivim/reason-textmate#57. I see no reason it should block this though. |
Thanks for looking at this! Agreed, not blocking 👍 |
015f365
to
0b42714
Compare
Brings in the changes onivim/reason-textmate#54 and onivim/reason-textmate#55 which added parsing of XML grammars and themes, respectively, to reason-textmate.
Has so far been tested to work with:
Let me know if there's anything else we should test.
Fixes #912
Probably fixes #1486
Addresses #1471, but does not completely fix it. See comment below