Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: XML Theme and Grammar support #1616

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

glennsl
Copy link
Member

@glennsl glennsl commented Apr 15, 2020

Brings in the changes onivim/reason-textmate#54 and onivim/reason-textmate#55 which added parsing of XML grammars and themes, respectively, to reason-textmate.

Has so far been tested to work with:

Let me know if there's anything else we should test.

Fixes #912
Probably fixes #1486
Addresses #1471, but does not completely fix it. See comment below

package.json Outdated Show resolved Hide resolved
@glennsl
Copy link
Member Author

glennsl commented Apr 15, 2020

https://github.com/vscode-restructuredtext/vscode-restructuredtext fails with "invalid backref number/name". Seems like a regex issue.

@bryphe
Copy link
Member

bryphe commented Apr 15, 2020

https://github.com/vscode-restructuredtext/vscode-restructuredtext fails with "invalid backref number/name". Seems like a regex issue.

Interesting... yes, seems unrelated to the new parsing logic (unless there's some sort of weird string escaping happening). But this seems unlikely since there are tests that would cover this. Must be exposing a pre-existing bug in our regex handling.

@bryphe
Copy link
Member

bryphe commented Apr 15, 2020

I get to test out the Duotone themes now! 🎉

image

@glennsl
Copy link
Member Author

glennsl commented Apr 15, 2020

https://github.com/SuperiorServers/vscode-glua fails because it doesn't have a repository

@glennsl
Copy link
Member Author

glennsl commented Apr 15, 2020

After making repository optional, that one fails with "invalid backref" too.

@glennsl glennsl marked this pull request as draft April 15, 2020 17:32
@glennsl
Copy link
Member Author

glennsl commented Apr 15, 2020

I created a PR for the invalid backref problem at onivim/reason-textmate#57. I see no reason it should block this though.

@glennsl glennsl marked this pull request as ready for review April 15, 2020 18:51
@bryphe
Copy link
Member

bryphe commented Apr 15, 2020

I created a PR for the invalid backref problem at onivim/reason-textmate#57. I see no reason it should block this though.

Thanks for looking at this! Agreed, not blocking 👍

@glennsl glennsl force-pushed the feature/theme+grammar/xml-parser branch from 015f365 to 0b42714 Compare April 15, 2020 20:54
@glennsl glennsl merged commit 3f4c659 into onivim:master Apr 16, 2020
@glennsl glennsl deleted the feature/theme+grammar/xml-parser branch April 16, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window freezes on Ctrl + Shift + P and searching - Windows 10 Support non-JSON Textmate Grammars and Themes
2 participants