Extension Host: Send correct parent PID #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update package.json * Update lockfiles
* Initial integration * Revert vsync change * Start adding extension host client Reason API * Initial ExtensionHost client start-up * Get extension host running * Hook up entry point to process messages * Add basic test case to verify we get 'Ready' message from extension host * Formatting * Tweak runner * Factor protocol out * Fix ExtHostProtocol path * Formatting * Fix merge conflict * Start stubbing out InitDat * Get ExtensionHostInitData compiling * Formatting * Debugging exception on startup * Refactor interface, test for 'initialized' event * Formatting * Remove logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension host checks to see if the 'parent process' is alive - if not, it'll close out. This is because on Windows, when the 'parent process' dies, the 'child processes' (extension host) don't necessarily die with it.
To facilitate this - we need to send the PID and set the
VSCODE_PARENT_PIDenvironment variable.The
Unix.getpid()doesn't actually return the Windows PID that the node logic expects... it returns a process handle. I've added a helper to rench to get the correct PID: revery-ui/rench#23 so that this works, as well as a regression test.Depends on #189